MAINT: Remove private _security submodule #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was made to avoid breaking changes the original PR introduced. We want to remove the outdated parameters, but not at the moment. See https://pypdf.readthedocs.io/en/latest/dev/deprecations.html Full credit for the work goes to exiledkingcc via PR #1816 Co-authored-by: exiledkingcc <exiledkingcc@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1935 +/- ##
==========================================
+ Coverage 93.41% 93.90% +0.48%
==========================================
Files 34 33 -1
Lines 7076 6986 -90
Branches 1397 1382 -15
==========================================
- Hits 6610 6560 -50
+ Misses 312 274 -38
+ Partials 154 152 -2
☔ View full report in Codecov by Sentry. |
MartinThoma
added a commit
that referenced
this pull request
Jul 2, 2023
New Features (ENH): - Add AES support for encrypting PDF files (#1918, #1935, #1936, #1938) - Add page deletion feature to PdfWriter (#1843) Bug Fixes (BUG): - PdfReader.get_fields() attempts to delete non-existing index "/Off" (#1933) - Remove unused objects when cloning_from (#1926) - Add the TK.SIZE into the trailer (#1911) - add_named_destination() maintains named destination list sort order (#1930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was made to avoid breaking changes the original PR introduced. We want to remove the outdated parameters, but not at the moment. See https://pypdf.readthedocs.io/en/latest/dev/deprecations.html
Full credit for the work goes to exiledkingcc via PR #1816