Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deprecate the encryption_key parameter of write_to_stream #1936

Merged
merged 3 commits into from
Jul 2, 2023

Conversation

MartinThoma
Copy link
Member

Partially taken from #1816

Partially taken from #1816

Co-authored-by: exiledkingcc <exiledkingcc@gmail.com>
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Patch coverage: 64.28% and project coverage change: -0.01 ⚠️

Comparison is base (c3279f7) 93.90% compared to head (1868007) 93.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
- Coverage   93.90%   93.89%   -0.01%     
==========================================
  Files          33       33              
  Lines        6986     6983       -3     
  Branches     1382     1382              
==========================================
- Hits         6560     6557       -3     
  Misses        274      274              
  Partials      152      152              
Impacted Files Coverage Δ
pypdf/_encryption.py 94.95% <ø> (-0.02%) ⬇️
pypdf/_writer.py 88.43% <ø> (-0.01%) ⬇️
pypdf/generic/_base.py 100.00% <ø> (ø)
pypdf/xmp.py 98.67% <0.00%> (ø)
pypdf/generic/_data_structures.py 91.09% <50.00%> (ø)
pypdf/generic/_outline.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MartinThoma MartinThoma force-pushed the 1816/deprecate-encryption-key-param branch from d882308 to 5d5e6f8 Compare July 2, 2023 18:48
@MartinThoma MartinThoma force-pushed the 1816/deprecate-encryption-key-param branch from 5d5e6f8 to 1868007 Compare July 2, 2023 19:29
@MartinThoma MartinThoma merged commit 2b47d9a into main Jul 2, 2023
@MartinThoma MartinThoma deleted the 1816/deprecate-encryption-key-param branch July 2, 2023 21:06
MartinThoma added a commit that referenced this pull request Jul 2, 2023
New Features (ENH):
-  Add AES support for encrypting PDF files (#1918, #1935, #1936, #1938)
-  Add page deletion feature to PdfWriter (#1843)

Bug Fixes (BUG):
-  PdfReader.get_fields() attempts to delete non-existing index "/Off" (#1933)
-  Remove unused objects when cloning_from (#1926)
-  Add the TK.SIZE into the trailer (#1911)
-  add_named_destination() maintains named destination list sort order (#1930)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant