Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support with and without isolation mode. #39

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Support with and without isolation mode. #39

merged 1 commit into from
Mar 1, 2022

Conversation

Paebbels
Copy link
Member

New Features

  • Added a 3rd overload for parameter requirements in job template Package:
    1. When requirements is empty
      → build Python package with build in isolation mode. (old behavior)
    2. When requirements is no-isolation
      → build Python package with build in non-isolation mode. (intended behavior since last release, but it had side-effects)
    3. When requirements is any other string
      → build Python package with setuptools using the given requirements.txt file to install build dependencies.

Changes

None

Bug Fixes

  • Restore old behavior (run build in isolation mode using venv).

Copy link
Member

@umarcor umarcor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@umarcor umarcor merged commit 8cfda1f into dev Mar 1, 2022
@Paebbels Paebbels deleted the isolation-modes branch March 1, 2022 22:35
umarcor added a commit to edaa-org/pyEDAA.UCIS that referenced this pull request Mar 14, 2022
# New Features

* Added news section at the documentation landing page.
* Added Jinja template for autoapi to change the class documentation layout.

# Changes

* Bumped dependencies.
* Removed Work-in-Progress banner.
* Changed package state from `alpha` to `stable`.
* Updated PR template.

# Bug Fixes

* Fixed some typos.

-------------------
# Related PRs:

* pyTooling/Actions#39 (dependency)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants