-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create s Security Policy #4671
Create s Security Policy #4671
Conversation
Not sure how to fix Format check, should I add .md file anywhere in here https://github.com/pybind/pybind11/blob/master/.pre-commit-config.yaml ? |
That particular error can probably be fixed by adding the new filename in tests/extra_python_package/test_files.py I'm not sure about:
MANIFEST.in:include LICENSE README.rst pyproject.toml setup.py setup.cfg |
As far as I've seen the SECURITY.md file is always placed in the root of the project but I couldn't find any official document arguing about that so I'd say it is up to us to decide. But considering that it seems that the standard place to it is in the root folder and that the Security Policy is supposed to be "easy to find" I'd say the best option is to keep it in the root folder. But let me know if you disagree with that and I can change it to .github folder. |
Sounds good to me. |
You can ignore this failure, it's a very frequent flake: CI / 🐍 pypy-3.7 • windows-2022 • x64 (pull_request) Failing after 7m You can basically ignore all PyPy and test_iostream failures if you see them in future CI runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joyce!
I looked around a bit to see if we may have to include the new filename elsewhere, but came out convinced that this PR captures everything we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joyce!
I looked around a bit to see if we may have to include the new filename elsewhere, but came out convinced that this PR captures everything we need.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Joyce!
I looked around a bit to see if we may have to include the new filename elsewhere, but came out convinced that this PR captures everything we need.
I removed the needs changelog label, because nothing really changed in pybind11 itself. If someone feels we should have this in the changelog, please add back the label and update the PR description. |
@rwgk please remember to enable the Vulnerability Through Security Advisory feature, otherwise the link https://github.com/pybind/pybind11/security/advisories/new won't work. Thanks! |
@henryiii could you please help? (I think I don't have the required permissions.) |
Description
Closes #4670
I've created the SECURITY.md file considering the report vulnerability through security advisory, which is a new github feature.
If you're interested in GitHub's feature, it must be activated for the repository:
If you rather not enable it there is also the possibility to receive the vulnerability report through an email, in this case just let me know which email it would be and I'll submit the change.
Besides that, feel free to edit or suggest any changes to this document, it is supposed to reflect the amount of effort the team can offer to handle vulnerabilities.