-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update changelog, with target date for v2.11.0 release #4677
Conversation
I'll be doing some stuff for Pyodide support, would like to make sure that's working before a release - including a pyodide CI job I've been working on using out-of-tree testing using scikit-build-core (which is really cool, but broken by a bug in emscripten I'm working on). I'll be at the scientific-python developer summit all next week, and won't have much time to finish that up till after I expect, so targeting a time after that would be preferable, I think. I have a feeling 2.10's date was related to SciPy. Did you use nox to generate the (initial draft) of the changelog update? |
docs/changelog.rst
Outdated
``CMAKE_INTERPROCEDURAL_OPTIMIZATION`` is defined. | ||
`#4643 <https://github.com/pybind/pybind11/pull/4643>`_ | ||
|
||
* No longer inject -stdlib=libc++, not needed for modern Pythons (macOS 10.9+). |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/changelog.rst
Outdated
* Introduce recursive_container_traits. | ||
`#4623 <https://github.com/pybind/pybind11/pull/4623>`_ | ||
|
||
* pybind11/type_caster_pyobject_ptr.h was added to support automatic wrapping |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/changelog.rst
Outdated
|
||
Changes will be summarized here periodically. | ||
* Introduce recursive_container_traits. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
docs/changelog.rst
Outdated
no longer converted to Python (only to be discarded). | ||
`#4621 <https://github.com/pybind/pybind11/pull/4621>`_ | ||
|
||
* Allow lambda specified to function definition to be noexcept(true) in C++17. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied, thanks!
I changed the target date to June 2, do you think that could work? I don't have a direct interest in releases (I work against latest master everywhere), but the thought that people are spending hours debugging GIL issues unnecessarily makes me a bit sad; #4246 is still only on master, but in no release. I believe exactly the people who're likely to benefit the most, those with limited experience, will also be the ones least likely to work against master.
I looked, but then decided to simply try |
I think the v2.11.0 release could also be a good opportunity to purge Python 3.6 support. End of life was already 23 Dec 2021, 1 year 4 months ago. That would get rid of all I could do the work (I think it's only a couple hours), but
|
Since 2.11 is almost out and all the work is already there to keep in on 3.6, would it be better to drop 3.6 right after? No strong reason to keep supporting imo, only manylinux is left still supporting 3.6. Could you drop the Version number change them merge? That way the labels can be cleared before new PRs are added (like the notes one). First beta of 3.12 is out soon! |
This reverts commit afc8013.
Sounds good. That way it'll live ~1 year longer in the latest release series, but won't bother us anymore on master.
Dropped and ready to merge (I'll change the title first).
Do we clear them manually?
With cpython main from a few hours ago the pybind11 unit tests only build, pytest dies at startup: python/cpython#103912 (comment) |
It is out now, with two bugs I knew about ahead of time, which means we cannot do much with 3.12 beta 1 :-( One bug is fixed already (even before the cut but it was too late anyway). The other I/we still have to figure out. |
Easy enough: done. |
Description
We have a lot of accumulated changes. Proposed release date: June 2, 2023
Note for easy reference: v2.10.0 was released on Jul 15, 2022.
Please help proof-reading the changelog.
PRs to be merged before the release (please review or comment by June 2):
format_descriptor<>
&npy_format_descriptor<>
PyObject *
specializations. #4674__notes__
toerror_already_set::what()
output. #4678Suggested changelog entry: