Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass extra argument in arguments validator #1094

Merged
merged 5 commits into from
Nov 30, 2023
+71 −62

remove extra traits

0e1dedd
Select commit
Loading
Failed to load commit list.
Merged

pass extra argument in arguments validator #1094

remove extra traits
0e1dedd
Select commit
Loading
Failed to load commit list.
CodSpeed HQ / CodSpeed Performance Analysis failed Nov 27, 2023 in 0s

Performance Regression: -18.28%

Summary

❌ 2 regressions
✅ 138 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main andresliszt:add/extra-arguments-validator Change
❌ test_core_str 31 µs 37.9 µs -18.25%
❌ test_core_future_str 31.3 µs 38.3 µs -18.28%
View more details on CodSpeed HQ