Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customise logo link in theme.conf #1664

Closed
dstansby opened this issue Jan 19, 2024 · 0 comments · Fixed by #1850
Closed

Add option to customise logo link in theme.conf #1664

dstansby opened this issue Jan 19, 2024 · 0 comments · Fixed by #1850

Comments

@dstansby
Copy link
Contributor

dstansby commented Jan 19, 2024

In matplotlib we have a sphinx theme that is a thin wrapper around pydata-sphinx-theme to provide consistent configuration across multiple projects. This is implemented with a custom theme.conf file.

However not all options that can go into html_theme_options in conf.py are supported by theme.conf. Specifically we would like to set the default logo link in our theme.conf, which looking at the default theme.conf doesn't seem to be supported by pydata-sphinx-theme at the moment.

drammock added a commit that referenced this issue Jun 4, 2024
This fixes #1664,
I'm not a 100% sure if this is enough to let downstream projects set
custom links.

Should I also add any specific docs here?

I think we should also be able to remove this config setting if we can
move to theme.toml (as in
#1776).

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant