Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose logo_link in theme.conf #1850

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Expose logo_link in theme.conf #1850

merged 3 commits into from
Jun 4, 2024

Conversation

MridulS
Copy link
Contributor

@MridulS MridulS commented Jun 3, 2024

This fixes #1664, I'm not a 100% sure if this is enough to let downstream projects set custom links.

Should I also add any specific docs here?

I think we should also be able to remove this config setting if we can move to theme.toml (as in #1776).

@trallard trallard added the kind: enhancement New feature or request label Jun 4, 2024
Copy link
Collaborator

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MridulS

@drammock drammock merged commit 5042cb9 into pydata:main Jun 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to customise logo link in theme.conf
3 participants