-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: various fixes to print CSS. #1770
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code diff looks good to me but there are a lot of failing CI checks
hmm the I'll open another PR to fix that |
This should among other fix pydata#1745 When printing this hides - The pydata navbar - The announcement banner. - The "skip to main content" link. - The location breadcrumbs (in bd-header-article), without also hiding the container the full content is shifted by a dozen pixel hight and the end of the content get hidden behind the footer when printing. - The prev.next buttons a bottom of page. This does not hide the version warning banner as this is currently being worked on in another PR. I went the route of adding the bootstrat `d-print-none`, instead of adding custom css rules, I'm happy to do the opposite, but it seem the using bootstrap classes as that seems what is done in other places. I've also added a break-inside avoid in a few places, mostly to try-to avoid page breaks in the middle of codeblocks.
Merged |
Thanks ! |
Co-authored-by: Tania Allard <taniar.allard@gmail.com>
This should among other fix #1745
When printing this hides
- The pydata navbar
- The announcement banner.
- The "skip to main content" link.
- The location breadcrumbs (in bd-header-article), without also hiding
the container the full content is shifted by a dozen pixel hight and
the end of the content get hidden behind the footer when printing.
- The prev.next buttons a bottom of page.
This does not hide the version warning banner as this is currently being
worked on in another PR.
I went the route of adding the bootstrap
d-print-none
, instead ofadding custom css rules, I'm happy to do the opposite, but it seem the
using bootstrap classes as that seems what is done in other places.
I've also added a break-inside avoid in a few places, mostly to try-to
avoid page breaks in the middle of codeblocks.