-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install sphinx test dependencies in all CI testing jobs #1772
Conversation
hmm, all the pytest jobs pass now, but the build-site jobs all fail with:
not sure if it's related or coincidence, will look tommorow if possible unless someone else has time to look first. |
See sunpy/ablog#277 for the error message. |
Right so for now we might want to pin our Sphinx version until there is a fix in |
🤔 So the last two changes fix our CI for docs and the Read the docs build but, of course, break when we try and install the "dev" Sphinx version from GitHub https://github.com/pydata/pydata-sphinx-theme/actions/runs/8741568491/job/23987894819?pr=1772#step:5:76 |
One way to get the CI to pass is to revert the pin in
|
Sorry about ablog, I am in the process of patching it and doing a release when/if my CI passes. Edit: I have tagged the release, it should be out on pypi shortly |
Ok I can try with the upcoming tag in Ablog. Actually testing against dev helps identify breaking changes against Sphinx. So it served it's purpose even if it gave us a bit of a headache. As I am working on the CI improvements I see a path here:
WDYT @drammock |
Yeah a periodic bump test sounds good. Thanks @trallard |
But so we then keep in the failing dev test? Or hope/ wait until it works with new ablog version |
I am logging off but I can try with the newest Ablog release tomorrow or try a quick fix to uninstall/install the Dev sphinx version while the bigger CI overhaul gets finished |
There is both a new version of sphinx that will temporarily fix the crash (though it might affect ablog's configuration), and a blog that will work if sphinx ever raise an error again. |
494e60c
to
cfaee23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, will go ahead and merge and work on the other CI PR so we can merge that one quickly too
* CI: install sphinx test deps always * fix it right this time * pin sphinx<7.3 for site builds * Fix Sphinx version * Pin Sphinx in pyproject.toml * bump ablog; unpin sphinx --------- Co-authored-by: Tania Allard <taniar.allard@gmail.com>
* CI: install sphinx test deps always * fix it right this time * pin sphinx<7.3 for site builds * Fix Sphinx version * Pin Sphinx in pyproject.toml * bump ablog; unpin sphinx --------- Co-authored-by: Tania Allard <taniar.allard@gmail.com>
should fix CI failures appearing in e.g. #1770