-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add activate/deactivate hooks #452
Conversation
@pyenv/pyenv-core-maintainers and especially @yyuu : any second opinions on the hook invocation placement? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
personally i might not apply very much of customization on activate/deactivate to keep shell setup cleaner/simpler, however, i can understand that there are some demands to customize the behavior around them. i’m open to adopt this definitely (esp. with working patch 😉 )
@joshfrench Thank you for your contribution! |
activate
/deactivate
hooks have been discussed several times but I haven't seen a PR, so... here's one :)There are two test failures in
test/activate
andtest/deactivate
that I think are just me not fully understanding the stub system, do you mind taking a look and pointing me in the right direction? Thanks so much!Past discussions: