Skip to content

Commit

Permalink
chore: move yamllint config to pre-commit config (#205)
Browse files Browse the repository at this point in the history
@rusty1s This PR aims to further improve the overall structure of the
repository by moving the yamllint configuration within the
`pre-commit-config.yaml` file.

The only snippet in which the `.yamllint.yml` file was being used was
the pre-commit config file. yamllint [allows to have a custom
configuration without a config
file](https://yamllint.readthedocs.io/en/stable/configuration.html#custom-configuration-without-a-config-file)
by using the `-d` flag. Using this feature, we add a serialized version
of the config in the args parameter of the pre-commit config.

Similar to pyg-team/pytorch_geometric#6776
  • Loading branch information
SauravMaheshkar authored Feb 28, 2023
1 parent e792b5e commit 1760817
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ repos:
rev: v1.29.0
hooks:
- id: yamllint
args: [-c=.yamllint.yml]
name: Lint yaml
args: [-d, '{extends: default, rules: {line-length: disable, document-start: disable, truthy: {level: error}, braces: {max-spaces-inside: 1}}}']

- repo: https://github.com/regebro/pyroma
rev: "4.2"
Expand Down
9 changes: 0 additions & 9 deletions .yamllint.yml

This file was deleted.

0 comments on commit 1760817

Please sign in to comment.