chore: move yamllint config to pre-commit config
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
=======================================
Coverage 83.37% 83.37%
=======================================
Files 26 26
Lines 842 842
=======================================
Hits 702 702
Misses 140 140 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I've skipped updating |
rusty1s
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rusty1s This PR aims to further improve the overall structure of the repository by moving the yamllint configuration within the
pre-commit-config.yamlfile.The only snippet in which the
.yamllint.ymlfile was being used was the pre-commit config file. yamllint allows to have a custom configuration without a config file by using the-dflag. Using this feature, we add a serialized version of the config in the args parameter of the pre-commit config.Similar to pyg-team/pytorch_geometric#6776