-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate to pyproject.toml
for building package
#6880
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6880 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 436 436
Lines 23891 23891
=======================================
Hits 21806 21806
Misses 2085 2085 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rusty1s, the pre-commit checks are passing on my machine with the updated version of |
@rusty1s I think the |
Got it. Will try to get this in as part of our PyG 2.3 release. |
@rusty1s do you think this will get into the release (hopefully) happening on March 21 👀 |
Likely not, I would like to delay this to next week to guarantee that PyG 2.3 release goes smooth. |
Ahh of course, makes sense 👍🏽 |
@rusty1s Seems like there is a conflict in |
@rusty1s can you fix this merge conflict ? I'm not sure if simply bumping the version in |
Nvm, seems like Github Actions are down. |
It's working again:D @SauravMaheshkar Disabled |
Changes proposed by this PR can be summarized as follows :-
setup.py
in favour ofpyproject.toml
for packaging.pre-commit
configuration with an updated version ofpyroma
to check packaging quality ofpyproject.toml
.python -m build
.pyproject.toml
is the new standard for packaging python packages,setup.py
is now deprecated (first introduced in PEP 518 and later expanded in PEP 517, PEP 621 and PEP 660).