Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gh actions mac runners (gets us native M1 builds) #2494

Merged
merged 4 commits into from
May 8, 2024
Merged

Bump gh actions mac runners (gets us native M1 builds) #2494

merged 4 commits into from
May 8, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Oct 2, 2023 •
edited
Loading

The macos-14 runner runs on the M1 chips, now we can run all our builds natively without any cross compilation workarounds. This means that now we can also finally test our arm64 mac releases on CI

On the intel mac builds this should give a little speedup, as the macos-13 runner apparently has 4 cores instead of the 3 cores on macos 11/12 runners

@ankith26 ankith26 force-pushed the ankith26-macos-13 branch 2 times, most recently from 322d316 to 82dc9a8 Compare October 2, 2023 18:14
@yunline yunline added the CI Issue with the Continuous Integration (CI), the actions/bots that test things label Oct 15, 2023
@ankith26 ankith26 mentioned this pull request Nov 7, 2023
Merged
@ankith26 ankith26 changed the title Bump mac runners to macos13 Bump gh actions mac runners (gets us native M1 builds) Jan 30, 2024
@ankith26 ankith26 marked this pull request as ready for review January 31, 2024 07:15
@ankith26 ankith26 requested a review from a team as a code owner January 31, 2024 07:15
MyreMylar
MyreMylar approved these changes Feb 4, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes sense to me to be running on native M1 now.

@ankith26 ankith26 mentioned this pull request Feb 9, 2024
Closed
@ankith26 ankith26 force-pushed the ankith26-macos-13 branch from 7994df7 to a214f77 Compare March 1, 2024 18:51
@ankith26
Copy link
Member Author

ankith26 commented Mar 1, 2024

I have updated this PR to make it even simpler to approve, by leaving out a change that tried to modify parallel job usage (it was not giving a significant improvement anyways)

@ankith26 ankith26 force-pushed the ankith26-macos-13 branch from a214f77 to 8e6ee7f Compare March 19, 2024 05:05
@ankith26 ankith26 mentioned this pull request Mar 26, 2024
Closed
@cclauss
Copy link
Contributor

cclauss commented Apr 5, 2024 •
edited
Loading

GitHub Actions blog:

Over the next 12 weeks, jobs using the macos-latest runner label will migrate from macOS 12 (Monterey) to macOS 14 (Sonoma).

https://github.blog/changelog/2024-04-01-macos-14-sonoma-is-generally-available-and-the-latest-macos-runner-image

@ankith26 ankith26 force-pushed the ankith26-macos-13 branch 5 times, most recently from 759d75d to d889782 Compare April 13, 2024 09:16
@ankith26 ankith26 force-pushed the ankith26-macos-13 branch 5 times, most recently from 6de6d44 to 3881002 Compare April 20, 2024 15:59
@ankith26
Copy link
Member Author

Had to do a couple of updates to get this working again, as the runner imaged changed significantly since I made this PR. This PR is ready for review now, though.

@cclauss
Copy link
Contributor

cclauss commented May 8, 2024

This pull request has been open for 7+ months. .github/workflows/build-macos.yml still only tests on macos-12

This pull request attempts to make a single large and complex home run. Instead, it might be more effective to take an incremental approach of creating smaller PRs that are easier to reason about, review, and merge. At a minimum, we should already have one or more GitHub Actions jobs running on macos-13 (Intel x64) and one or more jobs that run on macos-14 (Apple SIlicon ARM64). In less than a month macOS 15 will be announced so our upgrades should keep moving.

@ankith26
Copy link
Member Author

ankith26 commented May 8, 2024

I would also have liked to do that, but the thing is all these changes are inherently linked. If I split up the changes into parts, the parts may individually start to fail.

And this PR isn't that big to begin with. It makes testing a one-time thing and also easier

ankith26 added 4 commits May 8, 2024 14:20
@ankith26
Bump mac runner to 13/14 (gets native M1)
5119334
@ankith26
Bump cibw to 2.17.0
548fb0e
@ankith26
Make updates needed for mac 14 arm64
517b72f
@ankith26
Bump libwavpack
69a7e0e 
Now that we build on arm mac natively we can enable arm
optimisations.
Also, this bump is important because without this the build
tries to include openssl
@ankith26 ankith26 force-pushed the ankith26-macos-13 branch from 25fce55 to 69a7e0e Compare May 8, 2024 08:51
oddbookworm
oddbookworm approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddbookworm oddbookworm added this to the 2.5.0 milestone May 8, 2024
@oddbookworm oddbookworm merged commit e78b6a0 into main May 8, 2024
38 checks passed
@ankith26 ankith26 deleted the ankith26-macos-13 branch May 8, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things macOS
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ankith26 @cclauss @MyreMylar @oddbookworm @yunline