Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install meson+ninja on buildscripts, bump glib #2549

Merged
merged 3 commits into from
Nov 26, 2023
Merged

Install meson+ninja on buildscripts, bump glib #2549

merged 3 commits into from
Nov 26, 2023

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Nov 6, 2023

This should serve as a base for future deps updates. After this PR, we should be able to install dependencies that support only meson (like the new glib version).

@ankith26 ankith26 requested a review from a team as a code owner November 6, 2023 06:42
@ankith26 ankith26 force-pushed the ankith26-deps-updates3 branch 2 times, most recently from 44715fd to 2d154cb Compare November 6, 2023 09:12
@yunline yunline added the build Compiling stuff label Nov 7, 2023
@ankith26 ankith26 force-pushed the ankith26-deps-updates3 branch 4 times, most recently from cddfd2c to 823f523 Compare November 7, 2023 12:57
@ankith26 ankith26 force-pushed the ankith26-deps-updates3 branch from 823f523 to d0c64c1 Compare November 7, 2023 13:55
@ankith26 ankith26 force-pushed the ankith26-deps-updates3 branch from d0c64c1 to 217009d Compare November 7, 2023 14:16
@ankith26 ankith26 mentioned this pull request Nov 7, 2023
Merged
@ankith26
Copy link
Member Author

ankith26 commented Nov 7, 2023 •
edited
Loading

As a side effect of this PR, we don't need to compile gettext ourself anymore, and that saves CI time because gettext is a heavy-ish dependency.

Also, I'd appreciate a mac tester to test this PR. To save your time I'd suggest directly testing #2494 as that PR uses this PR, then we can merge both in one after the other
EDIT: welp seems like that linked PR is somehow making build times worse, so IG it should still be draft for now

MyreMylar
MyreMylar approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ankith26 ankith26 mentioned this pull request Nov 20, 2023
Merged
@MyreMylar MyreMylar requested a review from Starbuck5 November 25, 2023 17:53
@Starbuck5 Starbuck5 merged commit a53106f into main Nov 26, 2023
27 checks passed
@Starbuck5 Starbuck5 added this to the 2.4.0 milestone Nov 26, 2023
@Starbuck5 Starbuck5 added dependencies CI Issue with the Continuous Integration (CI), the actions/bots that test things labels Nov 26, 2023
@ankith26 ankith26 deleted the ankith26-deps-updates3 branch November 26, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@MyreMylar MyreMylar MyreMylar approved these changes

Assignees
No one assigned
Labels
build Compiling stuff CI Issue with the Continuous Integration (CI), the actions/bots that test things dependencies
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ankith26 @MyreMylar @Starbuck5 @yunline