-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tempfile #1570
Use tempfile #1570
Conversation
…statement of tempfile
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, sounds like it would already substantially easier to use with this.
For the future: In case of compress=True
we might even skip the copy to the temp dir completely and just add directly to the tarfile. I would even argue that compress=False
is not useful.
Yes! And I even did the change locally, but then realized that it makes it more difficult to read the changes so I dropped it for this PR, but I will do it over the course of next week. |
With this PR, pyiron uses the functionality of
tempfile
to create a temporary directory instead of taking care of it by itself (thanks @srmnitc for the idea!). This one makes an important step because it is going to be possible to use the same name as the project inpr.pack
.