Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow undefined pack destination #1581

Merged
merged 11 commits into from
Aug 6, 2024
Merged

Allow undefined pack destination #1581

merged 11 commits into from
Aug 6, 2024

Conversation

samwaseda
Copy link
Member

Following this PR now pack doesn't require a destination path.

@samwaseda samwaseda added enhancement New feature or request minor add functionality in a backward compatible manner labels Aug 3, 2024
@samwaseda
Copy link
Member Author

And I also added type hinting

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@samwaseda samwaseda merged commit 8561fdd into main Aug 6, 2024
26 checks passed
@samwaseda samwaseda deleted the pack_error branch August 6, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor add functionality in a backward compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants