Change NoReturn to be encapsulated in strings (#1252)

* Change ``NoReturn`` to be encapsulated in strings

Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>

ChangeLog

@@ -12,6 +12,9 @@ What's New in astroid 2.8.6?
 ============================
 Release date: TBA
 
+* Fix bug with Python 3.7.0 / 3.7.1 and ``typing.NoReturn``.
+
+  Closes #1239
 
 
 What's New in astroid 2.8.5?

astroid/nodes/node_ng.py

@@ -32,10 +32,11 @@
 if TYPE_CHECKING:
     from astroid import nodes
 
-if sys.version_info >= (3, 6, 2):
-    from typing import NoReturn
-else:
-    from typing_extensions import NoReturn
+    if sys.version_info >= (3, 6, 2):
+        # To be fixed with https://github.com/PyCQA/pylint/pull/5316
+        from typing import NoReturn  # pylint: disable=unused-import
+    else:
+        from typing_extensions import NoReturn
 
 if sys.version_info >= (3, 8):
     from typing import Literal
@@ -276,7 +277,7 @@ def statement(self, *, future: Literal[True]) -> "nodes.Statement":
 
     def statement(
         self, *, future: Literal[None, True] = None
-    ) -> Union["nodes.Statement", "nodes.Module", NoReturn]:
+    ) -> Union["nodes.Statement", "nodes.Module", "NoReturn"]:
         """The first parent node, including self, marked as statement node.
 
         TODO: Deprecate the future parameter and only raise StatementMissing and return

astroid/nodes/scoped_nodes.py

@@ -662,7 +662,7 @@ def statement(self, *, future: Literal[True]) -> NoReturn:
 
     def statement(
         self, *, future: Literal[None, True] = None
-    ) -> Union[NoReturn, "Module"]:
+    ) -> Union["NoReturn", "Module"]:
         """The first parent node, including self, marked as statement node.
 
         When called on a :class:`Module` with the future parameter this raises an error.