Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change NoReturn to be encapsulated in strings #1252

Merged
merged 4 commits into from
Nov 18, 2021

Conversation

DanielNoord
Copy link
Collaborator

Steps

  • For new features or bug fixes, add a ChangeLog entry describing what your PR does.
  • Write a good description on what the PR does.

Description

Follow up to #1235

Closes #1239

Type of Changes

Type
🐛 Bug fix

Related Issue

@DanielNoord DanielNoord added this to the 2.8.6 milestone Nov 17, 2021
@cdce8p cdce8p self-requested a review November 17, 2021 23:25
ChangeLog Outdated Show resolved Hide resolved
Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
ChangeLog Outdated Show resolved Hide resolved
Copy link
Member

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DanielNoord 🐬

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Pierre-Sassoulas Pierre-Sassoulas merged commit 3e27d87 into pylint-dev:main Nov 18, 2021
@DanielNoord DanielNoord deleted the noreturn branch November 18, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Plain typing.NoReturn is not valid as type argument in Astroid 2.8.5 + Python 3.7.0/1
3 participants