Avoid duplicate inference results for List[int]
#2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This became necessary once we fixed the cache key in 0740a0d.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2185 +/- ##
=======================================
Coverage 92.61% 92.61%
=======================================
Files 94 94
Lines 10812 10813 +1
=======================================
+ Hits 10013 10014 +1
Misses 799 799
Flags with carried forward coverage won't be shown. Click here to find out more.
|
DanielNoord
approved these changes
May 19, 2023
| @@ -316,6 +316,9 @@ def infer_typing_alias( | |||
| # This is an issue in cases where the aliased class implements it, | |||
| # but the typing alias isn't subscriptable. E.g., `typing.ByteString` for PY39+ | |||
| _forbid_class_getitem_access(class_def) | |||
|
|
|||
| # Avoid re-instantiating this class every time it's seen | |||
| node._explicit_inference = lambda node, context: iter([class_def]) | |||
There was a problem hiding this comment.
This feels like something we might need to do for a lot of brains.
We us a similar pattern for the enum brain. π
There was a problem hiding this comment.
You're quite right. I traced the bulk of the primer noise to needing to do this in other places in the typing brain.
This was referenced Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Fix a regression in 3.0.0.a3 that became necessary once we fixed the cache key in 0740a0d.
If we re-run the inference function for inferring a slice like
List[int], we risk creating so many duplicates, especially if used in several files, that we hit the limit for max inference and end up introducing anUninferable, which can cause some pylint checks to not fire.This explains (and resolves!) the failures seen in pylint-dev/pylint#8685 (comment), which we were only seeing when running the test suite as a whole.
Skipping news because we're not writing changelogs specific to each alpha.
This should unblock pylint-dev/pylint#8685.