Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[primer noise] deprecated-typing-alias #9220

Closed
jacobtylerwalls opened this issue Nov 5, 2023 · 1 comment · Fixed by pylint-dev/astroid#2340
Closed

[primer noise] deprecated-typing-alias #9220

jacobtylerwalls opened this issue Nov 5, 2023 · 1 comment · Fixed by pylint-dev/astroid#2340
Assignees
@jacobtylerwalls
Labels
Astroid Related to astroid Bug 🪲 Needs PR This issue is accepted, sufficiently specified and now needs an implementation primer

Comments

@jacobtylerwalls
Copy link
Member

Found a reproducible case for some of the primer noise we see constantly.

  1. clone pytest @ cdddd6d69533c07092c64445a0d42d1fc75c8299
  2. cd to src/_pytest
  3. Compare:
  • pylint *.py --disable=all --enable-all-extensions --enable=deprecated-typing-alias: 647 messages
  • pylint *.py --disable=all --enable-all-extensions --enable=deprecated-typing-alias,used-before-assignment: 585 messages
@jacobtylerwalls jacobtylerwalls added Bug 🪲 primer Needs PR This issue is accepted, sufficiently specified and now needs an implementation labels Nov 5, 2023
@jacobtylerwalls jacobtylerwalls self-assigned this Dec 10, 2023
@jacobtylerwalls jacobtylerwalls added the Astroid Related to astroid label Dec 10, 2023
@jacobtylerwalls
Copy link
Member Author

Same issue as pylint-dev/astroid#2185 -- need to apply the fix all over the typing brain.

@jacobtylerwalls jacobtylerwalls linked a pull request Dec 10, 2023 that will close this issue
Avoid duplicate inference results for Tuple[Optional[int], ...] pylint-dev/astroid#2340
Merged
@jacobtylerwalls jacobtylerwalls mentioned this issue Dec 12, 2023
Merged
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 20, 2023
@derekstraka @kraj
python3-astroid: update to version 3.0.2
1b12d40 
Changelog
* Avoid duplicate inference results for some uses of typing.X constructs like Tuple[Optional[int], ...].
  This was causing pylint to occasionally omit messages like deprecated-typing-alias.

Closes pylint-dev/pylint#9220

Signed-off-by: Derek Straka <derek@asterius.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Dec 21, 2023
@derekstraka @kraj
python3-astroid: update to version 3.0.2
6a1d075 
Changelog
* Avoid duplicate inference results for some uses of typing.X constructs like Tuple[Optional[int], ...].
  This was causing pylint to occasionally omit messages like deprecated-typing-alias.

Closes pylint-dev/pylint#9220

Signed-off-by: Derek Straka <derek@asterius.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@derekstraka @kraj
src/meta-openembedded:python3-astroid: update to version 3.0.2
7ebbc47 
Changelog
* Avoid duplicate inference results for some uses of typing.X constructs like Tuple[Optional[int], ...].
  This was causing pylint to occasionally omit messages like deprecated-typing-alias.

Closes pylint-dev/pylint#9220

Signed-off-by: Derek Straka <derek@asterius.io>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
Astroid Related to astroid Bug 🪲 Needs PR This issue is accepted, sufficiently specified and now needs an implementation primer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid duplicate inference results for Tuple[Optional[int], ...] jacobtylerwalls/astroid
1 participant
@jacobtylerwalls