-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow and packaging improvements #4116
Conversation
We should probably also update the |
@Pierre-Sassoulas I noticed an issue with pinning the I see two solutions here:
Option 2 might be the better one IMO. For testing it should be enough to loosen the requirement in the -- |
I think we disabled the benchmark tests in Github Actions at some point, and we should launch them at least once, I'll create an issue. |
I haven't added them since they did not run before either. Just pushed a commit to include them. I'll check what's causing the issue later. Interestingly |
|
It's a problem with astroid Astroid 2.4.2 is sufficient for pylint to pass all pylint tests in python 3.8, I guess 3.9 is another matter. I did not have time to bisect the bug in astroid yet. |
I though so, but tox was using Anyway, I've removed the |
* Pin test and doc requirements to current versions * Rename requirements_test_pypy.txt to requirements_test_min.txt * Move some dependencies from min to test * Update coverage and sphinx versions * Update ci * Use pytest-cov
Rebase to catch up with current master (which added the benchmark CI job). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I like the use of requirement file in tox in particular. I might have missed something as this is hard to review. I'll wait for other reviewers to check as well because continuous integration tests are really important.
Steps
doc/whatsnew/<current release.rst>
.Description
Replaces: #4111
It started with just some CI improvements, but got a bit bigger in the end.
Since almost all changes are workflow related it should be possible to later include the MR in the
2.7.1
release.Changes
test
requirements to current versionsrequirements _test_pypy.txt
torequirements_test_min.txt
min
totest
coverage
dependency to==5.4.0
, instead of<5.0
pytest-cov
as wrapper forcoverage
docs
requirements to current versionsrequirements
filesGPL-2.0-or-later
Important!
I've configured dependabot to add the
dependency
label to each MR it opens. This label needs to be created for it to work properly.Type of Changes
Related Issue