Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify tests for astroid update #4152

Merged
merged 3 commits into from
Feb 28, 2021
Merged

Modify tests for astroid update #4152

merged 3 commits into from
Feb 28, 2021

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Feb 27, 2021

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Type of Changes

Type
🐛 Bug fix

Related Issue

Closes: #4154

@Pierre-Sassoulas
Copy link
Member

Closing/Opening to relaunch the CI.

@cdce8p cdce8p marked this pull request as ready for review February 28, 2021 20:32
pylint/__pkginfo__.py Outdated Show resolved Hide resolved
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.7.2 milestone Feb 28, 2021
@coveralls
Copy link

coveralls commented Feb 28, 2021

Coverage Status

Coverage decreased (-0.03%) to 91.479% when pulling 0752267 on cdce8p:fix-test-mro into 64a25b9 on PyCQA:master.

@Pierre-Sassoulas
Copy link
Member

Test are failing because astroid has not been released even though the tag's job passed, I must look into it : https://travis-ci.org/github/PyCQA/astroid/builds/760835652

@cdce8p
Copy link
Member Author

cdce8p commented Feb 28, 2021

With the updated version constraint, the CI tests are failing. #4116 should solve that. Might be an idea to squash merge it to make rebasing easier.

@cdce8p
Copy link
Member Author

cdce8p commented Feb 28, 2021

Test are failing because astroid has not been released even though the tag's job passed, I must look into it : https://travis-ci.org/github/PyCQA/astroid/builds/760835652

The old tox config uses the current master branch commit from astroid. The current version is 2.6.0-dev which doesn't match the requirements. I changed that behavior with #4116. I could port parts of it over, but it's probably easier and safer to just merge it.

@Pierre-Sassoulas
Copy link
Member

OK, astroid do not have the automatic pypi release on tag, I had to release manually. I hope I did not fucked it up like I did for pylint 2.6.1.

@cdce8p
Copy link
Member Author

cdce8p commented Feb 28, 2021

OK, astroid do not have the automatic pypi release on tag, I had to release manually. I hope I did not fucked it up like I did for pylint 2.6.1.

The release works! I messed up a bit by not updating the requirements file at first. It is fixed now.

@Pierre-Sassoulas Pierre-Sassoulas merged commit 0e1beac into pylint-dev:master Feb 28, 2021
@cdce8p cdce8p deleted the fix-test-mro branch February 28, 2021 21:10
@Pierre-Sassoulas
Copy link
Member

This looks good, I must triage what I cherry-pick for 2.7.2 and we should be good to go. Thanks for all the works you did to make this possible in time for debian deadline !

@cdce8p
Copy link
Member Author

cdce8p commented Feb 28, 2021

Thanks, but without your help and that of @hippo91 it wouldn't have been possible.
Just as a heads up, you need to include most (if not all) of #4116 or the tests might fail.

@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow and removed task labels Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive invalid-name with dataclass ClassVar
3 participants