Require python `3.7.2+` #5921

DanielNoord · 2022-03-15T12:09:47Z

Add yourself to CONTRIBUTORS.txt if you are a new contributor.
Add a ChangeLog entry describing what your PR does.
If it's a new feature, or an important bug fix, add a What's New entry in
doc/whatsnew/<current release.rst>.
Write a good description on what the PR does.

Type of Changes

	Type
✓	✨ New feature
✓	📜 Docs

Description

Two additional follow up PRs would be necessary after this:

Remove all tests options for min_pyver=3.7. That would be quite a large diff so I have excluded it from this PR.
Update py-version in pylintrc. This causes a number of warnings about using from __future__ import annotations. So that warrants its own PR.
We might want to run https://github.com/cdce8p/python-typing-update before doing step 2 just to see what can be automated

Just a draft to see if I got everything that needs to be changed for an initial PR.

Closes #4310
First step toward #4683

coveralls · 2022-03-15T12:16:18Z

Pull Request Test Coverage Report for Build 2147752109

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
4 unchanged lines in 3 files lost coverage.
Overall coverage decreased (-0.03%) to 93.875%

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/classes/class_checker.py	1	94.24%
pylint/config/arguments_manager.py	1	89.33%
pylint/checkers/base/name_checker/checker.py	2	98.15%

Totals
Change from base Build 2147474687:	-0.03%
Covered Lines:	15878
Relevant Lines:	16914

💛 - Coveralls

DanielNoord · 2022-03-15T12:28:54Z

With respect to coverage. The first decrease seems "correct", it is no longer covered. Do we want to remove it?

The second coverage decline comes from assign-to-new-keyword become irrelevant. There are no new keywords introduced after 3.7 (match and case are soft keywords), so the message will never be emitted for anything. Again, do we want to remove this? Or just keep it in the codebase without any coverage?

Pierre-Sassoulas

We could wait a little for this one to avoid issue with Python 3.6 when backporting fixes on 2.13. What do you think?

Pierre-Sassoulas · 2022-03-25T06:36:02Z

I think we should remove dead code no longer accessed.

DanielNoord · 2022-03-25T07:10:24Z

Fine with me! Shall we say first week of April?

Pierre-Sassoulas · 2022-03-26T21:41:03Z

Alternatively we could merge this release 2.14.0 without python 3.6 right now, and move everything that is in 2.14 now to 2.15.0 (then we support 2.14 and python 3.7).

cdce8p · 2022-03-26T21:51:02Z

I would suggest to wait a bit longer before dropping 3.6, even if it's only in a dev branch. Once it's committed, there sure will be a lot of cleanup and update PRs which will make bugfixes / backports even more difficult. A few weeks more or even a month doesn't make much of a difference IMO.

Alternatively we could merge this release 2.14.0 without python 3.6 right now

Additionally, it would be better not to release new minor versions with so little time after one another. The fast bugfix releases are much appreciated though!

Pierre-Sassoulas · 2022-03-26T22:00:38Z

Once it's committed, there sure will be a lot of cleanup and update PRs which will make bugfixes / backports even more difficult.

The idea I had (following #5988 where the test fail for python 3.6) is to not do any bug fixes for python 3.6 / pylint 2.13 and just support pylint 2.14 / python 3.7.

cdce8p · 2022-03-26T22:30:36Z

Once it's committed, there sure will be a lot of cleanup and update PRs which will make bugfixes / backports even more difficult.

The idea I had (following #5988 where the test fail for python 3.6) is to not do any bug fixes for python 3.6 / pylint 2.13 and just support pylint 2.14 / python 3.7.

🤔 Not sure about that. I would still recommend to wait. I agree pylint 2.14.0 should be the one which requires 3.7, but it would make more sense to include the whole cleanup there as well.

Until we're ready, bugfixes for 2.13.x still need to be tested on 3.6.

After all, the particular issue with 3.6 wasn't a big deal and easy to resolve. It should be possible to support it for a few more weeks now, too.

cdce8p

Not a full review, but from what I've seen this looks about right.

Some notes

We didn't add CI tests for pypy-3.8, right?
This should definitely be done separately, but we should make sure to update py-version. Just a warning, that might trigger a lot a pylint typing warning 😄
https://github.com/PyCQA/pylint/blob/96d7e898cc863a6854cd0870ba4069c8f7d7851b/pylintrc#L56-L57

cdce8p · 2022-03-26T23:02:17Z

pylint/extensions/typing.py

@@ -361,12 +361,9 @@ def _check_broken_noreturn(self, node: Union[nodes.Name, nodes.Attribute]) -> No
            if (
                isinstance(inferred, (nodes.FunctionDef, nodes.ClassDef))
                and inferred.qname() in TYPING_NORETURN
-                # In Python 3.6, NoReturn is alias of '_NoReturn'
-                # In Python 3.7 - 3.8, NoReturn is alias of '_SpecialForm'


I would leave the second line.

DanielNoord · 2022-03-26T23:15:35Z

We didn't add CI tests for pypy-3.8, right?

No we need to exclude line number checking. Something for another PR :)

This should definitely be done separately, but we should make sure to update py-version. Just a warning, that might trigger a lot a pylint typing warning 😄
https://github.com/PyCQA/pylint/blob/96d7e898cc863a6854cd0870ba4069c8f7d7851b/pylintrc#L56-L57

I tried, and yeah that's also something for a follow-up 😄 See OP.

Pierre-Sassoulas · 2022-03-26T23:18:05Z

we should make sure to update py-version

There's a checklist in #4683 I assumed we were going to do it later on, but doing the whole checklist here would make sense.

cdce8p · 2022-03-26T23:19:27Z

we should make sure to update py-version

There's a checklist in #4683 I assumed we were going to do it later on, but doing the whole checklist here would make sense.

Not so sure about that. It might be easier to review if they are split up into multiple PRs.

DanielNoord · 2022-04-06T07:06:52Z

@Pierre-Sassoulas Shall we merge this Monday 11th? We could do one final hotfix this weekend if needed without the trouble of having the hotfix supporting 3.6 and main 3.7. After that we will probably need to be a little more picky when choosing whether something needs to be back ported.

Pierre-Sassoulas · 2022-04-06T07:21:17Z

Yes let's do it. I think we can (try to) release 2.14 fairly soon after. This way we don't have to backport to 2.13 and think about python 3.6 anymore

DanielNoord · 2022-04-06T07:22:49Z

Yes let's do it. I think we can (try to) release 2.14 fairly soon after. This way we don't have to backport to 2.13 and think about python 3.6 anymore

There is quite a lot still on the argparse to-do list, but I agree. We should be able to do 2.14 much sooner than the gap between 2.12 and 2.13. Especially with the speed we have been merging lately.

pylint/extensions/typing.py

jacobtylerwalls · 2022-04-11T09:58:06Z

The plan is still to merge this after a likely 2.13.6? Or are we cancelling that milestone?

DanielNoord · 2022-04-11T09:59:22Z

The plan is still to merge this after a likely 2.13.6? Or are we cancelling that milestone?

I think so, but I think we can already finish the review of the changes here. I'll fix the merge conflict first though.

Pierre-Sassoulas · 2022-04-11T10:43:17Z

The plan is still to merge this after a likely 2.13.6?

I need to create a test for the namespace changes but I've been quite busy lately and the main blocker for 2.13.6 is #6141 that needs to be reviewed by Marc ideally. We could release 2.13.6 without this issue in the worst case scenario. And the issue with 3.6 would be manageable anyway. I think we can merge this one.

tests/functional/d/deprecated/deprecated_method_getmoduleinfo.txt

Require python 3.7.2+

00d0384

DanielNoord added Blocker 🙅 Blocks the next release python 3.7 Maintenance Discussion or action around maintaining pylint or the dev workflow labels Mar 15, 2022

DanielNoord added this to the 2.14.0 milestone Mar 15, 2022

Remove env from tox

daa225d

DanielNoord mentioned this pull request Mar 15, 2022

To-do list for 2.14.0 #5513

Closed

15 tasks

DanielNoord marked this pull request as ready for review March 24, 2022 22:58

DanielNoord requested review from Pierre-Sassoulas and cdce8p and removed request for Pierre-Sassoulas March 24, 2022 22:58

Pierre-Sassoulas reviewed Mar 25, 2022

View reviewed changes

Pierre-Sassoulas mentioned this pull request Mar 26, 2022

Add regression test for #5982 #5988

Merged

Pierre-Sassoulas mentioned this pull request Mar 26, 2022

Remove support for Python 3.6 and future Python support #4310

Closed

cdce8p reviewed Mar 26, 2022

View reviewed changes

DanielNoord mentioned this pull request Apr 2, 2022

Use argparse config handler on three checkers #6124

Merged

2 tasks

This was referenced Apr 4, 2022

Update pre-commit requirement from ~=2.17 to ~=2.18 #6177

Merged

Update tbump requirement from ~=6.6.0 to ~=6.7.0 #5600

Merged

Merge branch 'main' of https://github.com/PyCQA/pylint into 3.7

e8ae078

DanielNoord removed the Blocker 🙅 Blocks the next release label Apr 11, 2022

DanielNoord requested a review from jacobtylerwalls April 11, 2022 09:16

DanielNoord mentioned this pull request Apr 11, 2022

Cleanup after we drop support for Python 3.6 #4683

Closed

6 tasks

DanielNoord commented Apr 11, 2022

View reviewed changes

pylint/extensions/typing.py Show resolved Hide resolved

Update pylint/extensions/typing.py

ca18fc0

Merge branch 'main' of https://github.com/PyCQA/pylint into 3.7

a5c9cab

DanielNoord added the Blocked 🚧 Blocked by a particular issue label Apr 11, 2022

Add changelog

58a09b2

jacobtylerwalls requested changes Apr 11, 2022

View reviewed changes

tests/functional/d/deprecated/deprecated_method_getmoduleinfo.txt Show resolved Hide resolved

jacobtylerwalls approved these changes Apr 11, 2022

View reviewed changes

DanielNoord requested a review from Pierre-Sassoulas April 11, 2022 12:42

Pierre-Sassoulas approved these changes Apr 11, 2022

View reviewed changes

Pierre-Sassoulas merged commit dfd23f6 into pylint-dev:main Apr 11, 2022

Pierre-Sassoulas removed the Blocked 🚧 Blocked by a particular issue label Apr 11, 2022

DanielNoord deleted the 3.7 branch April 11, 2022 13:24

DanielNoord mentioned this pull request Apr 21, 2022

Remove assign-to-new-keyword #6421

Merged

4 tasks

jacobtylerwalls mentioned this pull request May 4, 2022

Require Python 3.7.2 pylint-dev/astroid#1542

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Require python `3.7.2+` #5921

Require python `3.7.2+` #5921

DanielNoord commented Mar 15, 2022 •

edited

Loading

coveralls commented Mar 15, 2022 •

edited

Loading

DanielNoord commented Mar 15, 2022

Pierre-Sassoulas left a comment

Pierre-Sassoulas commented Mar 25, 2022

DanielNoord commented Mar 25, 2022

Pierre-Sassoulas commented Mar 26, 2022 •

edited

Loading

cdce8p commented Mar 26, 2022

Pierre-Sassoulas commented Mar 26, 2022

cdce8p commented Mar 26, 2022

cdce8p left a comment

cdce8p Mar 26, 2022

DanielNoord commented Mar 26, 2022 •

edited

Loading

Pierre-Sassoulas commented Mar 26, 2022

cdce8p commented Mar 26, 2022

DanielNoord commented Apr 6, 2022

Pierre-Sassoulas commented Apr 6, 2022

DanielNoord commented Apr 6, 2022

jacobtylerwalls commented Apr 11, 2022

DanielNoord commented Apr 11, 2022

Pierre-Sassoulas commented Apr 11, 2022

Require python 3.7.2+ #5921

Require python 3.7.2+ #5921

Conversation

DanielNoord commented Mar 15, 2022 • edited Loading

Type of Changes

Description

coveralls commented Mar 15, 2022 • edited Loading

Pull Request Test Coverage Report for Build 2147752109

💛 - Coveralls

DanielNoord commented Mar 15, 2022

Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

Pierre-Sassoulas commented Mar 25, 2022

DanielNoord commented Mar 25, 2022

Pierre-Sassoulas commented Mar 26, 2022 • edited Loading

cdce8p commented Mar 26, 2022

Pierre-Sassoulas commented Mar 26, 2022

cdce8p commented Mar 26, 2022

cdce8p left a comment

Choose a reason for hiding this comment

cdce8p Mar 26, 2022

Choose a reason for hiding this comment

DanielNoord commented Mar 26, 2022 • edited Loading

Pierre-Sassoulas commented Mar 26, 2022

cdce8p commented Mar 26, 2022

DanielNoord commented Apr 6, 2022

Pierre-Sassoulas commented Apr 6, 2022

DanielNoord commented Apr 6, 2022

jacobtylerwalls commented Apr 11, 2022

DanielNoord commented Apr 11, 2022

Pierre-Sassoulas commented Apr 11, 2022

Require python `3.7.2+` #5921

Require python `3.7.2+` #5921

DanielNoord commented Mar 15, 2022 •

edited

Loading

coveralls commented Mar 15, 2022 •

edited

Loading

Pierre-Sassoulas commented Mar 26, 2022 •

edited

Loading

DanielNoord commented Mar 26, 2022 •

edited

Loading