Use python-typing-update on pylint/utils and message dirs
#6304
Conversation
DanielNoord
added
typing
Maintenance
| Tuple, | ||
| Union, | ||
| ) | ||
| from typing import TYPE_CHECKING, DefaultDict, Dict, Iterator |
There was a problem hiding this comment.
Just noticed Iterator and DefaultDict which could both be imported from collections.abc. For that to happen automatically, python-typing-update would need to be run with --py39-plus though. https://github.com/asottile/reorder_python_imports#rewriting-pep-585-typing-imports
Maybe that's worth doing after the initial round of changes, since it could also include incompatible changes. Otherwise pylint should also detect deprecated typing aliases once we update the py-version setting.
There was a problem hiding this comment.
Hm, yeah I was wondering about DefaultDict anyway. This PR includes a line where a defaultdict is typed as dict. That might also be something we want to change? Manual check of all defaultdicts wouldn't hurt I guess.
There was a problem hiding this comment.
Small update, for python-typing-update, both the --py39-plus and --full-reorder setting are necessary to rewrite all PEP 585 typing aliases. https://github.com/cdce8p/python-typing-update#configuration
However, this might also change runtime code (e.g. in type aliases). Might be best to just use the consider-using-alias check for it. (With py-version = 3.7.2)
There was a problem hiding this comment.
Yeah I saw one too just now. Fine with me, let's do these changes first and see what pylint reports for us!
Pull Request Test Coverage Report for Build 2166014898
💛 - Coveralls |
Type of Changes
Description
Ref #4683.