Use UninferableBase instead of Uninferable

[DanielNoord]

Type of Changes

	Type
✓	🔨 Refactoring

Description

Blocked on the new astroid release.

[Pierre-Sassoulas]

I thought UninferableBase was for typing purpose only ? I like the is Uninferable a lot, it's pretty pythonic imo.

[DanielNoord]

I thought UninferableBase was for typing purpose only ? I like the is Uninferable a lot, it's pretty pythonic imo.

We made a similar change in astroid as well, see pylint-dev/astroid#1741.

The isinstance check helps actually narrow down the type of these variables for mypy and other tools so I guess it makes sense to do this here as well.

[codecov]

Codecov Report

Merging #8384 (3bf0c78) into main (9c4fbed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8384   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         178      178           
  Lines       18763    18764    +1     
=======================================
+ Hits        17932    17934    +2     
+ Misses        831      830    -1     

Impacted Files	Coverage Δ
pylint/checkers/async.py	97.77% <100.00%> (ø)
pylint/checkers/base/basic_checker.py	97.87% <100.00%> (ø)
pylint/checkers/classes/class_checker.py	93.73% <100.00%> (ø)
pylint/checkers/classes/special_methods_checker.py	95.48% <100.00%> (ø)
pylint/checkers/dunder_methods.py	100.00% <100.00%> (ø)
pylint/checkers/exceptions.py	97.85% <100.00%> (ø)
...heckers/refactoring/implicit_booleaness_checker.py	100.00% <100.00%> (ø)
pylint/checkers/refactoring/refactoring_checker.py	98.33% <100.00%> (ø)
pylint/checkers/stdlib.py	96.70% <100.00%> (ø)
pylint/checkers/strings.py	94.07% <100.00%> (ø)
... and 7 more

[jacobtylerwalls]

Nice FP fixes in the primer comment related to #5288/#8385.

[jacobtylerwalls]

Unrelated to this PR, but this looks fishy. Why would Uninferable be in a tuple of lists? 🤔

[DanielNoord]

Yeah.. I guess elts is Uninferable sometimes? Or this is just 100% broken..

[jacobtylerwalls]

Would you mind opening a follow up issue to investigate?

[Pierre-Sassoulas]

👍 But blocked by #8387 I guess.

[github-actions]

🤖 Effect of this PR on checked open source code: 🤖

Effect on music21:
The following messages are no longer emitted:

1. unsubscriptable-object:
   Value 'midiEventList' is unsubscriptable
   https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/midi/translate.py#L1359

Effect on sentry:
The following messages are no longer emitted:

1. unsubscriptable-object:
   Value '_from_email_domain_cache' is unsubscriptable
   https://github.com/getsentry/sentry/blob/5959c5be7a50c32cc79c98447807bf0521994a17/src/sentry/utils/email/address.py#L26

This comment was generated for commit 3bf0c78