Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for #5288 #8385

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

jacobtylerwalls
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Closes #5288

@jacobtylerwalls jacobtylerwalls added the Needs astroid update Needs an astroid update (probably a release too) before being mergable label Mar 5, 2023
@jacobtylerwalls jacobtylerwalls added this to the 2.17.0 milestone Mar 5, 2023
@Pierre-Sassoulas Pierre-Sassoulas added Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry and removed Needs astroid update Needs an astroid update (probably a release too) before being mergable labels Mar 6, 2023
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on music21:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value 'midiEventList' is unsubscriptable
    https://github.com/cuthbertLab/music21/blob/aacc7aa37552f216a698d8af9e5ea3c685cf8cc2/music21/midi/translate.py#L1359

Effect on sentry:
The following messages are no longer emitted:

  1. unsubscriptable-object:
    Value '_from_email_domain_cache' is unsubscriptable
    https://github.com/getsentry/sentry/blob/241223720f050fe400725885db77eac922bf107c/src/sentry/utils/email/address.py#L26

This comment was generated for commit 0facedd

@Pierre-Sassoulas
Copy link
Member

Created #8387 to upgrade astroid as there's non trivial deprecations to take care of.

@Pierre-Sassoulas Pierre-Sassoulas enabled auto-merge (squash) March 7, 2023 21:00
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #8385 (9f58a74) into main (b4fe93a) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8385   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files         178      178           
  Lines       18764    18764           
=======================================
  Hits        17934    17934           
  Misses        830      830           

@Pierre-Sassoulas Pierre-Sassoulas merged commit ca25497 into pylint-dev:main Mar 7, 2023
@jacobtylerwalls jacobtylerwalls deleted the issue-5288 branch March 7, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining pylint or the dev workflow Skip news πŸ”‡ This change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylint doesn't understand returns from functions using match case
2 participants