-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add regression test for #5288 #8385
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtylerwalls
added
the
Needs astroid update
Needs an astroid update (probably a release too) before being mergable
label
Mar 5, 2023
Pierre-Sassoulas
added
Maintenance
Discussion or action around maintaining pylint or the dev workflow
Skip news π
This change does not require a changelog entry
and removed
Needs astroid update
Needs an astroid update (probably a release too) before being mergable
labels
Mar 6, 2023
Pierre-Sassoulas
force-pushed
the
issue-5288
branch
from
March 6, 2023 08:29
bc06372
to
43e7497
Compare
Pierre-Sassoulas
previously approved these changes
Mar 6, 2023
This comment has been minimized.
This comment has been minimized.
π€ Effect of this PR on checked open source code: π€ Effect on music21:
Effect on sentry:
This comment was generated for commit 0facedd |
Created #8387 to upgrade astroid as there's non trivial deprecations to take care of. |
Pierre-Sassoulas
force-pushed
the
issue-5288
branch
from
March 7, 2023 21:00
0facedd
to
9f58a74
Compare
Pierre-Sassoulas
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Maintenance
Discussion or action around maintaining pylint or the dev workflow
Skip news π
This change does not require a changelog entry
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
Closes #5288