RTT_COMMAND: Allow no down-channels #1680
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no down-channel can be found, the target only supports printing RTT messages. Before this commit, this target-configuration was only possible to do when supplying a log file. Then commands were ignored and only the up-channel was written to the file. If no log-file was supplied, we detected the missing down-channels and returned an error, never starting the viewer_loop so no up-channel messages were printed on stdout. With this commit, instead of returning an error when no down-channels are configured, we inform the user and start the viewer_loop with a down-channel (parameter down_chan) with value 'None'. Inside the viewer_loop we detect the None-value of down_chan, drop the user supplied command and continue our viewer_loop.
|
Not sure what is stopping the jobs from starting? If I need to do something, do tell. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no down-channel can be found, the target only supports printing RTT messages.
Before this commit, this target-configuration was only possible to do when supplying a log file.
Then commands were ignored and only the up-channel was written to the file.
If no log-file was supplied, we detected the missing down-channels and returned an error, never starting the viewer_loop so no up-channel messages were printed on stdout.
With this commit,
instead of returning an error when no down-channels are configured, we inform the user and start the viewer_loop
with a down-channel (parameter down_chan) with value 'None'.
Inside the viewer_loop we detect the None-value of down_chan, drop the user supplied command and continue our viewer_loop.