Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTT_COMMAND: Allow no down-channels #1680

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

RTT_COMMAND: Allow no down-channels #1680

wants to merge 1 commit into from

Commits on Mar 24, 2024

  1. RTT_COMMAND: Allow no down-channels 

    If no down-channel can be found, the target only supports printing RTT
messages.

Before this commit, this target-configuration was only possible to do when
supplying a log file.
Then commands were ignored and only the up-channel was written to the
file.
If no log-file was supplied, we detected the missing down-channels and
returned an error, never starting the viewer_loop so no up-channel
messages were printed on stdout.

With this commit,
instead of returning an error when no down-channels are configured,
we inform the user and start the viewer_loop
with a down-channel (parameter down_chan) with value 'None'.

Inside the viewer_loop we detect the None-value of down_chan, drop the user
supplied command and continue our viewer_loop.
    Laurens Miers committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    cd7367c View commit details
    Browse the repository at this point in the history