Fix AppVeyor's PyPy failure on finding libffi #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YannickJadoul
force-pushed
the
pypy-appveyor-macos-brew-libffi
branch
from
c7d51d9 to
d8e0b54
Compare
YannickJadoul
changed the title
|
Progress. PyPy 2.7 now works with the fixes. Now waiting for a nightly build of 3.6 and maybe later a release with these fixes. |
This reverts commit f1c4ebb.
YannickJadoul
force-pushed
the
pypy-appveyor-macos-brew-libffi
branch
from
3877508 to
f909242
Compare
Closed
|
Assuming you don't want to merge this until these fixes are in an official Pypy release? |
|
Hmmm, I don't know. I guess we could ping PyPy again and ask what their short term plans on a patch release? I actually still need to fix a mistake I made in a PR on f-strings, there, that's probably blocking a release :-| I should get to that this weekend. |
|
Closing, since 7.3.2 is out and can almost be merged (see #430). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cfr. https://foss.heptapod.net/pypy/pypy/issues/3229 and https://foss.heptapod.net/pypy/pypy/merge_requests/726