-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to 3.9.0 final #440
Conversation
@henryiii, there's a nice script to do that, |
That's what I'm working on running (though I assume updating the constraints is fine, latests updates might be helpful for 3.9?), but I'm running into |
Those are virtualenvs that @joerick uses to update the package versions, I believe. I just comment out these lines when updating the images: |
Also, the PyPy failures should be fixed once #430 is merged. |
I'll just comment out the constraints part for now, looks like I'd have to use pyenv and setup multiple Pythons to run that update; assuming one of you already has it (will do it eventually). Looks like the macOS tests are failing due to PyPy 7.3.1? Or am I misreading that? |
By the way, do we need to have a 37 constraints file now? If you run it with 3.8, then |
I don't. I believe it's part of @joerick's steps when making a new release.
Yup, related to #371, https://foss.heptapod.net/pypy/pypy/issues/3229 and https://foss.heptapod.net/pypy/pypy/merge_requests/726.
We probably do, then, yes :-( |
@joerick Would you like me to add a env37/constraints37 setup, and start assuming that the "main" one runs at least 3.8 (which should be identical to 3.9, so a "38" constraints is still not needed)? @YannickJadoul What do we do about PyPy? And why is it just now breaking, as I didn't (knowingly) touch it? |
Maybe you can add this to the list of versions in
That I don't really know. The issue was linked to versions of the libraries installed in the environment. Did Azure and GHA update their images? (Always blame CI updates, when possible ;-) ) EDIT: If you want to check, you could rebase onto YannickJadoul:pypy-7.3.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging #430, things should turn green. At any rate, the failures are not related to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hurray! :-)
Niiiiice work @henryiii ! Thanks for doing that, and updating the docs :) Yep, this looks good to me, I'll try to push a release soon so we have a Python 3.9.0 version out there. |
Any idea why one AppVeyor job basically froze and timed out? https://ci.appveyor.com/project/joerick/cibuildwheel/builds/35599358/job/hiq0jff3cca76c4f Can someone restart it? Don't want to restart all jobs right now, since a) that's slow and b) GHA is currently having some degradation. |
Co-authored-by: Matthieu Darbois <mayeut@users.noreply.github.com>
Passed and several approvals, so merged! :) |
Python 3.9.0 was released yesterday. Nuget was fast, though Manylinux finally updated 5 hours ago
(do we pin a docker image? If not, this should just work?). Bumping macOS and Windows to 3.9.0. The other requirements should possibly be bumped before a release is made with 3.9.0 final, I think (@joerick?).Edit: Oops, they are pinned, just found that. Will update.