Permit local version string to be empty (e.g. "1.0+" equals "1.0") #150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This permits "2.7.15+" to be a valid Python version for
pythonfinder
. For details, see #149. It includes a test. I think that this is a safe change --2.7.15+foo
would be a valid version, as would2.7.15
, so permitting2.7.15+
to equal2.7.15
seems OK to me.Steps to reproduce (copy-pasting from #149)
I've tested that this fixes the issue for me.
Close #149
Before
Trying to run
pyfinder --findall
crashes.After
Running
pyfinder --findall
treats 2.7.15+ as 2.7.15.