-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonfinder crashes when system has Python 2.7.15+ #40
Comments
I’m guessing we are bad and should feel bad. What makes a versions specifier valid for python? I had no idea there was any system using Note that we have 0 tests against this library specifically and all of our tests are done via integration downstream in pipenv so it’s easy to miss things like this |
It's not too uncommon for distributors to ship a slightly patched version of projects like Python, and then they have... idiosyncratic ways of recording that. In this case I think Ubuntu is shipping something like a snapshot they pulled from the 2.7 dev branch, in order to include fixes that are more recent than the last 2.7 release, so "2.7.15+" means something like "a release in between 2.7.15 and 2.7.16". Other times I've run into this kind of issue:
That glibc version parsing code might be good enough for this case too? Depends on what you're trying to do. |
see pypa/pipenv#3241 pypa/pipenv#3232 @njsmith it's entirely likely that we can take advantage of the |
- Use graceful fallbacks on failure to parse versions - Continue iterating through paths when failures occur - Fixes #40 Signed-off-by: Dan Ryan <dan@danryan.co>
Thanks @techalchemy ! :D |
& thanks @njsmith and hi maybe we met at PyCon if you're the nice Trio person! |
That’s him :) he is very modest but he is a visionary and his thoughts about concurrency are playing a major role in redefining concurrent programming in numerous programming languages, I’m still flattered he is watching my projects |
👋 @techalchemy I didn't realize you had access to >>> sys.version
'2.7.15+ (default, Oct 2 2018, 22:12:08) \n[GCC 8.2.0]'
>>> sys.version_info
sys.version_info(major=2, minor=7, micro=15, releaselevel='final', serial=0) |
In any event the string doesn’t always come from invoking python which can have considerable overhead, I have some heuristics to try and pick out the version from the path if I think I’m dealing with python |
Hi there,
I've noticed that on Ubuntu 18.10,
pyfinder --findall
crashes. I've submitted a fix at pypa/packaging#150 but wanted to leave a note here in case someone Googles the issue and wonders what's going on.I'll close the issue here once that one is resolved, or we can discuss alternate ways to fix it within pythonfinder.
Best wishes!
The text was updated successfully, but these errors were encountered: