-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 24.1 #12613
Comments
Do we expect the If the |
Yes. If no one else has bandwidth, I'd be willing to be the RM for this one. I expect we're going to have a beta period, to get some user feedback on the legacy version removal situation (thank you to @sbidoul for doing most of the work on #12300!) and to also make follow up fixes we'd likely need. |
OK, if we're putting the packaging upgrade in, I'll leave it with you. I'm happy to help where I can, so feel free to ping me if you think I can help. I'll try to find some time to review @sbidoul's PR in the next day or two. |
Regarding a beta release, I'm not entirely convinced it will help (my instinct says not enough people will notice/care), but that's up to the RM, of course ;) |
I would test a beta and I'm sure @potiuk would as well, I would also try to spread the word on social media as much as possible. However, I will say, the one time that pip recently had a beta it didn't get much exposure. On release though, I will again mention that resolving is not sound #12317 and I have a fix here if anyone has time to provide any more feed back sarugaku/resolvelib#144 Also this PR seems fairly small and would be a great performance news item for Pip #12453 (and more complex but would be a big UX improvement news item, would be #12388 and #12404 if they are considered close to ready) |
A summary on macos runners which are currently blocking CI runs:
So it needs to be decided whether to keep running x86 as well as ARM (#12593) or just stick with "latest" which is now ARM (#12617). And someone either needs to fix this test (I don't know what the issue is and have no way to reproduce locally) or whether to exclude Python 3.8 and 3.9 from MacOS ARM. |
I'd also like to nominate #12657 for 24.1, it's very simple, and I've measured a significant performance improvement on large number of packages to resolve, and even a slight perfornance improvement on small number of packages to resolve. |
Oh wow, this month has flown by. I'm catching up on my RM duties now. 😅 |
I did report small issue while ago: useless warnings in "pip list --outdated --verbose". |
I know this was asked by Paul above and answered, but is the Do you expect the 24.1 release before the Python 3.13 beta 1? |
I posted a status update on the PR: #12300 (comment) |
As it seems there's very likely to be a beta that hopefully will get some wide coverage, I would like to make the case for pip maintainers to be a little bit more agressive merging approved open PRs that are in a good state: I appreciate pip is under resourced and generally conservative in accepting PRs, but having a long open approved unmerged PR can be a little demoralizing to potential future contributors. |
I've moved a few of those onto the 24.1 milestone, where I think they are clear-cut ones that should be merged. The others I think might need a little more consideration than I have time for right now. (I'm not arguing against them, though). |
OK, we're almost all set for 24.1b1 to be released today. I have one outstanding PR to merge and then will cut a release after grabbing lunch today. |
https://pypi.org/project/pip/24.1b1/ is up. I'm not updating get-pip.py or filing a PR to CPython with an updated wheel for this. |
Are you going to post an announcement on discuss.python.org? It might be a good way to attract a few more beta testers. |
Yep, I plan to do that along with a blog post that serves as a call for beta testing. That'll all have to be after my work day today though, since pip maintainance isn't a part of my day job anymore. |
FYI. I can confirm that the most complex case with installation and eager upgrade for latest airflow version with 24.1b1 works fine. Not super comprehensive, but passes as "smoke test" IMHO |
@potiuk Is it meaningfully quicker? :) |
Not too scientific but looks like ~ 15% (~550 seconds -> ~470 seconds) - on a very small sample. |
Roughly what is that running? Anything that gets stuck doing a bit of backtracking should see more significant performance gains. But if the versions here are all tightly constrained that is about in line with what I would expect. |
Roughly this:
|
Probably actions/setup-python#886 ? You could manually set 3.13.0b1 for a bit to unblock. Looks like 3.12.4 might have the same issue. |
Pin using |
I’d mangle the setup-python call instead. Easier and doesn’t change the job name. Something like |
A workaround shouldn't be needed anymore. Broken versions were removed from the manifest. |
And, we're green! Thanks all! |
24.1b2 works great for us and fixes the problem described in #12613 (comment) 🙌 |
Also Airlfow build works nicely with |
Alright, #12777 is up. I'll push all the relevant knobs tonight / tomorrow night depending on my availability. |
Alrighty, all done with the button clicking for now.
|
If possible, it'd be great to have it in time for Tuesday's 3.13.0b3. |
@hugovk Thanks for that nudge -- made the PR now, given that there's not really any major showstoppers AFAICT with this release. |
I believe #12781 needs more attention. My cursory analysis is that the new tar extraction logic fails for tars which contains hard links, but it wasn't clear to me why, and neither the regular Python extraction or the data filter extraction failed, perhaps I am wrong in my analysis. |
See my comments there. I'm not sure we want to rush a fix for 24.1.1, as I think the subtleties involved warrant deeper consideration, and a "quick fix" might just leave us with further issues. |
FWIW, I guess I should mention this explicitlt: |
OK, assuming I don't see any fires in the next few minutes about 24.1.2 (uploaded to PyPI and get-pip.py has also been updated), I'm gonna say this doozy of a release is done with. And, I'll move on toward making 24.2 next weekend. 😅 |
Ok, gonna say about 25 minutes is enough time. Thanks everyone for helping make this release happen -- this was a surprisingly long release cycle to manage. We had hiccups and a bunch of technical details needed to be figured out and yet this went by without major disruption... and, overall, quite smoothly! |
It's April already.
Any @pypa/pip-committers up to take the RM hat this month?
The text was updated successfully, but these errors were encountered: