-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI Tests on both MacOS Arm and x86 #12593
Conversation
121064c
to
6b08efc
Compare
Well they pass, and complete faster than any of the other workers, so seems like there's little reason not to enable? Marking ready for review. |
6b08efc
to
6c8a64f
Compare
Pip's macos-latest runner is now macos-14 causing pip CI to fail: https://github.com/pypa/pip/actions/runs/8825862850/job/24230722241 This PR supports continuing to test x86 and ARM, where as my alternative PR fixes pip CI just for ARM: #12617 |
9d59d97
to
70826ad
Compare
This failure is new:
I guess it's a flaky test? I have no way to try to reproduce. |
70826ad
to
a61325a
Compare
Yup, I forced CI to rerun and this time the test passed. |
a61325a
to
1bcc4f3
Compare
8abf028
to
95c319e
Compare
So this PR is updated to run MacOS 12 (x86) on all versions of Python, and MacOS Latest (M1) on Python versions >= 3.10, as 3.8 and 3.9 have a failing test (test_uninstall_editable_from_usersite). |
b4875b3
to
128e32d
Compare
FWIW, I think this PR is worth merging, |
Can a maintainer yay or nay this, I'll close the PR if nay. To summaraize:
|
I'm closing this PR as I don't like keeping PRs open and stale. It's very easy for someone else to recreate, and I've made a GitHub issue to be tracked #12908 |
It occured to me that pip tests currently only run on MacOS x86, which at this point could be considered problematic.
Checking the documentation (https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) it appears that you must manually specify which version of MacOS you want to get the Arm version.
This probably could be done a little more elegantly but first I wanted to see if all tests would pass on Arm.