Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip CI should be tested against MacOS ARM (M1) #12908

Closed
1 task done
notatallshaw opened this issue Aug 10, 2024 · 5 comments · Fixed by #12919
Closed
1 task done

Pip CI should be tested against MacOS ARM (M1) #12908

notatallshaw opened this issue Aug 10, 2024 · 5 comments · Fixed by #12919
Labels
state: needs eyes Needs a maintainer/triager to take a closer look type: maintenance Related to Development and Maintenance Processes

Comments

@notatallshaw
Copy link
Member

What's the problem this feature will solve?

MacOS ARM (M1) is a very popular user platform, but currently Pip's CI only runs against MacOS x86, which at this point is deminishing rapidly in terms of users who are on it

Describe the solution you'd like

Enable MacOS ARM (M1) via the macos-latest GitHub runners

Alternative Solutions

Well, at some point macos-12 will stop being supported by GitHub so the alternative is eventually not testing against MacOS

Additional context

Last I checked Python 3.8 and 3.9 had a failing test (test_uninstall_editable_from_usersite) on MacOS ARM, but Python 3.10+ all worked fine.

Code of Conduct

@notatallshaw notatallshaw added type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Aug 10, 2024
@uranusjr
Copy link
Member

I think it’d be reasonable enough to keep 3.8 and 3.9 on Intel and only run 3.10+ on ARM. We’re probably going to drop 3.8 before GHA drops macos-12. They only just dropped 11 in June, and 10 was dropped in 2022, so 2026 should be a reasonable deadline for 12. That’s roughly the timeline we should drop 3.8 anyway.

3.9 is more problematic, but we can probably figure something out when we need to. Worst case scenario we can just skip the test (those usersite tests are known to be problematic due to system configurations)

@ichard26 ichard26 added type: maintenance Related to Development and Maintenance Processes state: needs eyes Needs a maintainer/triager to take a closer look and removed type: feature request Request for a new feature S: needs triage Issues/PRs that need to be triaged labels Aug 14, 2024
@ichard26
Copy link
Member

Even if the number of Python users on MacOS x86 is declining, is it going to continue being a substantial amount? I tried to find some data on this, but I wasn't able to (I don't use MacOS at all). I'm totally in favour of adding MacOS ARM to our CI matrix (gating it to Python 3.10+) but I'm less sure of removing Python 3.10+ on Intel from CI.

@notatallshaw
Copy link
Member Author

I don't propose removing MacOS x86 while the github runners are still available.

@ichard26
Copy link
Member

We’re probably going to drop 3.8 before GHA drops macos-12

macos-12 is now deprecated and will no longer exist after December 3rd this year. We can migrate to macos-13 to retain CI coverage on Intel MacOS for at least a few more months after that.

@notatallshaw
Copy link
Member Author

I think it makes sense to switch macos-12 to macos-13, as well as test macos-latest.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
state: needs eyes Needs a maintainer/triager to take a closer look type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants