Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Test on macOS arm64 #12919

Merged
merged 2 commits into from
Aug 30, 2024
Merged

CI: Test on macOS arm64 #12919

merged 2 commits into from
Aug 30, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented Aug 17, 2024

Fix #12908

The 2 failing tests mentioned in the issue are indeed present and marked as fail in the PR.
The tests required virtualenv >= 20.0 to pass on python 3.8 & 3.9 on arm64 thus the requirements have been updated.

Side note: it seems all tests are passing with virtualenv >= 20.0 on other platforms. The pin to virtualenv<20.0 might not be needed anymore (introduced in #11288, @uranusjr might have some valuable insight about this).

@notatallshaw
Copy link
Member

Well done, I somehow figured out and then subsequently forgot about virtualenv (#12617 (comment)).

Copy link
Member

@ichard26 ichard26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@uranusjr
Copy link
Member

IIRC virtualenv has <20 mostly just I didn’t want to risk rocking the boat too much on older platforms. I didn’t actually check if the CI works on older Python versions with new virtualenv at all.

If you are inclined to do some reviews (mostly needing to check tests that use the user site are testing the right things), we can probably remove the pin. I think we’re good to just keep the pins though, it’s less work.

@notatallshaw notatallshaw added this to the 24.3 milestone Aug 22, 2024
@uranusjr uranusjr merged commit b989e6e into pypa:main Aug 30, 2024
33 checks passed
@mayeut mayeut deleted the ci-mac-arm64 branch August 31, 2024 10:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip CI should be tested against MacOS ARM (M1)
4 participants