CI: Test on macOS arm64 #12919
Merged
CI: Test on macOS arm64 #12919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done, I somehow figured out and then subsequently forgot about virtualenv (#12617 (comment)). |
|
IIRC virtualenv has If you are inclined to do some reviews (mostly needing to check tests that use the user site are testing the right things), we can probably remove the pin. I think we’re good to just keep the pins though, it’s less work. |
uranusjr
reviewed
Aug 20, 2024
uranusjr
approved these changes
Aug 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12908
The 2 failing tests mentioned in the issue are indeed present and marked as fail in the PR.
The tests required virtualenv >= 20.0 to pass on python 3.8 & 3.9 on arm64 thus the requirements have been updated.
Side note: it seems all tests are passing with virtualenv >= 20.0 on other platforms. The pin to virtualenv<20.0 might not be needed anymore (introduced in #11288, @uranusjr might have some valuable insight about this).