-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document that "coding: utf-8" is supported in requirements.txt #7182
Comments
@chrahunt could you possibly link to the corresponding code? I looked in https://github.com/pypa/pip/blob/master/src/pip/_internal/req/req_file.py and can't figure out where exactly the behavior you're pointing out is implemented. |
Sure. It's done in
|
That's deeeep. And, there's a doc-fix worth making in download.get_file_content. |
Hey I am working on this in PyCon India 2019 Devsprint. As per my understanding I am supposed to update documentation in Requirements File Format and download.get_file_content |
As mentioned in #6401 (comment), requirements files support
# -*- coding: utf-8 -*-
declarations. Some details about this convention can be found here.A sentence should be added to the Requirements File Format section of the docs saying that this is supported, for users that want their requirements files to always be interpreted as UTF-8 no matter what.
Good First Issue: This issue is a good starting point for first time contributors -- the process of fixing this should be a good introduction to pip's development workflow. If you've already contributed to pip, work on another issue without this label instead. If there is not a corresponding pull request for this issue, it is up for grabs. For directions for getting set up, see our Getting Started Guide. If you are working on this issue and have questions, feel free to ask them here,
#pypa-dev
on Freenode, or the pypa-dev mailing list.The text was updated successfully, but these errors were encountered: