Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that "coding: utf-8" is supported in requirements.txt #7195

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Document that "coding: utf-8" is supported in requirements.txt #7195

merged 1 commit into from
Nov 1, 2019

Conversation

ananyo2012
Copy link
Contributor

Fixes #7182

@ananyo2012 ananyo2012 force-pushed the utf8-doc branch 2 times, most recently from aa7820c to d4cc484 Compare October 14, 2019 12:26
@ananyo2012 ananyo2012 closed this Oct 15, 2019
@ananyo2012 ananyo2012 reopened this Oct 15, 2019
@pradyunsg pradyunsg requested a review from chrahunt October 15, 2019 13:32
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Oct 18, 2019
chrahunt
chrahunt suggested changes Oct 29, 2019
View reviewed changes
docs/html/reference/pip_install.rst Outdated Show resolved Hide resolved
src/pip/_internal/download.py Outdated Show resolved Hide resolved
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Oct 31, 2019
@ananyo2012 ananyo2012 closed this Oct 31, 2019
@ananyo2012 ananyo2012 reopened this Oct 31, 2019
@ananyo2012
Copy link
Contributor Author

@chrahunt Updated. Please have a look again.

chrahunt
chrahunt approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@chrahunt chrahunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!!

@chrahunt chrahunt merged commit 5538244 into pypa:master Nov 1, 2019
@ananyo2012 ananyo2012 deleted the utf8-doc branch November 1, 2019 06:29
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Dec 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chrahunt chrahunt chrahunt approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document that "coding: utf-8" is supported in requirements.txt
4 participants
@ananyo2012 @BrownTruck @chrahunt @pypa-bot