-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use pep 517 when the 'wheel' package is absent #11871
Always use pep 517 when the 'wheel' package is absent #11871
Conversation
666f3e3
to
ffcf590
Compare
Lots of tests are failing, because they now try to install setuptools in an isolated env and they don't have access to it. Let's see how it goes when we always install |
887d236
to
b159aff
Compare
Alright, only test failing: |
30c0ad2
to
d32afa6
Compare
If it is now required for complete functionality, shouldn't pip explicitly depend on wheel? |
Actually, wheel is not required, just like setuptools is not required. If you try to install a project that has a Unless you use |
So |
Thanks for the investigation @uranusjr. I think I'll mark this test xfail. |
Ok, I marked that last test about colons in console script names xfail. I'm done with the |
This test will become useless anyway when we remove setup.py install support.
Adapt to the removal of the setup.py install code path.
wheel is now installed in our test venv by default.
console_script entrypoints declarations are stricter when we don't use setup.py install.
We now look for "Building wheel" instead of "running setup.py install"
Run setup.py install manually since pip does not do it anymore.
We install wheel by default in our test env.
This was supported by setup.py install but not by our wheel installation logic.
a6dc754
to
8f52335
Compare
I've rebased this on the latest |
It would be annoying if you see an error about setuptools, install it, and only be greeted by another error telling you to install wheel. So we combine the two into one.
Thanks for the review, folks! |
closes #8559
TODO
with_wheel
fixturetest_debian_egg_name_workaround