Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop setup.py install support #11874

Merged
merged 6 commits into from
Mar 31, 2023
Merged

Drop setup.py install support #11874

merged 6 commits into from
Mar 31, 2023

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Mar 18, 2023 •
edited
Loading

@sbidoul sbidoul added this to the 23.1 milestone Mar 18, 2023
@sbidoul sbidoul changed the title Drop setup.py install support [WIP] Drop setup.py install support Mar 18, 2023
@sbidoul sbidoul changed the title [WIP] Drop setup.py install support [WIP] Drop setup.py install support Mar 19, 2023
@sbidoul sbidoul added project: setuptools Related to setuptools type: deprecation Related to deprecation / removal. labels Mar 21, 2023
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Mar 27, 2023
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 27, 2023
@sbidoul sbidoul changed the title [WIP] Drop setup.py install support Drop setup.py install support Mar 27, 2023
@sbidoul sbidoul marked this pull request as ready for review March 27, 2023 15:56
@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Mar 27, 2023
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 27, 2023
@sbidoul sbidoul mentioned this pull request Mar 27, 2023
Closed
@sbidoul
Copy link
Member Author

sbidoul commented Mar 28, 2023

🟢

uranusjr
uranusjr reviewed Mar 28, 2023
View reviewed changes
src/pip/_internal/req/req_install.py
Comment on lines -763 to +760
global_options=global_options,
global_options=global_options if global_options is not None else [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics only. Since the variable is not used anywhere else, I figured I'd inline it.

@sbidoul
Copy link
Member Author

sbidoul commented Mar 29, 2023

If there are no objections, I plan to merge this on Friday or Saturday so it lands on time for 23.1.

@sbidoul sbidoul mentioned this pull request Mar 29, 2023
Closed
@kkpan11 kkpan11 mentioned this pull request Mar 30, 2023
Closed
1 task
@sbidoul
Don't fallback to setup.py install when build failed
48986a6
@sbidoul
Remove setup.py install legacy
bc3feef
@sbidoul
Fix test_install_requirements_with_options
64967c7 
This test depended on setup.py install, and tbh, I don't see a good
reason to attempt an install when testing the requirements file parser.
@sbidoul
Rework test_show_with_files_from_legacy
0060bfa 
It relied on a function that does not exist anymore.
@sbidoul
Adapt test to the removal of setup.py install code path
e5deb4d
@sbidoul sbidoul merged commit 295a35b into pypa:main Mar 31, 2023
@sbidoul sbidoul deleted the drop-setup-py-install-sbi branch March 31, 2023 20:41
@jameslamb jameslamb mentioned this pull request Apr 3, 2023
Closed
@astrojuanlu astrojuanlu mentioned this pull request Apr 6, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
project: setuptools Related to setuptools type: deprecation Related to deprecation / removal.
Projects
None yet
Milestone
23.1
3 participants
@sbidoul @uranusjr @pypa-bot