Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Run pip check in pip install #4820

Closed
wants to merge 4 commits into from
Closed

[WIP] Run pip check in pip install #4820

wants to merge 4 commits into from

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Oct 28, 2017 •
edited
Loading

RFC @pypa/pip-committers

TODO:

  • Handle installed-extras
  • Tests
  • Documentation
  • News

I have a feeling that there's some edge case I've missed.

@pradyunsg pradyunsg added state: needs discussion This needs some more discussion type: feature request Request for a new feature type: refactor Refactoring code C: dependency resolution About choosing which dependencies to install kind: workaround Is a workaround for a problem labels Oct 28, 2017
@pradyunsg pradyunsg added this to the 10.0 milestone Oct 28, 2017
@pradyunsg pradyunsg self-assigned this Oct 28, 2017
@pradyunsg pradyunsg changed the title Run pip check after pip install [WIP] Run pip check after pip install Oct 28, 2017
@pradyunsg pradyunsg force-pushed the resolver/warn-after-resolution branch from 4a80bcc to 74833b4 Compare October 29, 2017 12:24
@pradyunsg pradyunsg changed the title [WIP] Run pip check after pip install [WIP] Run pip check in pip install Oct 29, 2017
@pradyunsg pradyunsg force-pushed the resolver/warn-after-resolution branch 2 times, most recently from 73d8b4e to 47c1de2 Compare October 29, 2017 13:25
@pradyunsg
Copy link
Member Author

It'll be awesome if someone could review this in it's current state since I'd appreciate some input on how this feels to other people.

Also, does pip store information about extras installed for a package? In the little time I had, I couldn't find it.

@pradyunsg pradyunsg mentioned this pull request Nov 1, 2017
Closed
@pradyunsg
Rework pip check to not use Distribution objects
a491bd8 
While there is no change in functionality, this change makes it
possible to reuse the pip check logic by uncoupling it from the
Distribution objects, as returned by get_installed_distributions.
@pradyunsg
Improve pip check
4de7e3b 
pip check also prints the specifier when a dependency is not installed
@pradyunsg
Run pip check in pip install
a2d8a28 
Also, add --no-warn-conflicts option to allow supressing the error
messages generated.
@pradyunsg
Add tests related to normailization of names
84a7e21
@pradyunsg pradyunsg force-pushed the resolver/warn-after-resolution branch from 2d041b2 to 84a7e21 Compare November 3, 2017 17:08
@pradyunsg
Copy link
Member Author

Pinging @pypa/pip-committers!

PS: There'll be an email about "installed-extras" in your inboxes. :)

pradyunsg
pradyunsg commented Nov 5, 2017
View reviewed changes
tests/functional/test_install.py
result2 = script.pip(
'install', '--no-index', pkgB_path, '--no-warn-conflicts'
)
assert "Successfully installed pkgB-2.0" in result2.stdout, str(result2)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add assert "pkga 1.0 has requirement pkgb==1.0" not in result2.stderr, str(result2)

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Nov 12, 2017
@pradyunsg
Copy link
Member Author

Closing this for now, until there's a path forward with the extras situation.

@pradyunsg pradyunsg closed this Nov 28, 2017
@pradyunsg pradyunsg removed the request for review from pfmoore November 28, 2017 04:25
@pradyunsg pradyunsg removed state: needs discussion This needs some more discussion type: refactor Refactoring code needs rebase or merge PR has conflicts with current master kind: workaround Is a workaround for a problem labels Nov 28, 2017
@pradyunsg pradyunsg removed this from the 10.0 milestone Nov 28, 2017
@pradyunsg pradyunsg reopened this Jan 21, 2018
@pypa-bot
Copy link

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@pypa-bot pypa-bot added the needs rebase or merge PR has conflicts with current master label Jan 21, 2018
@pradyunsg
Copy link
Member Author

Imma gonna pick this up again.

@pradyunsg
Copy link
Member Author

Actually, I'll make a new PR. This one looks messy. :)

@pradyunsg pradyunsg closed this Jan 21, 2018
@pradyunsg pradyunsg mentioned this pull request Jan 29, 2018
Merged
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pradyunsg pradyunsg

Labels
auto-locked Outdated issues that have been locked by automation C: dependency resolution About choosing which dependencies to install needs rebase or merge PR has conflicts with current master type: feature request Request for a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pradyunsg @BrownTruck @pypa-bot