Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about broken dependencies during pip install #5000

Merged
merged 24 commits into from
Mar 30, 2018

Conversation

pradyunsg
Copy link
Member

@pradyunsg pradyunsg commented Jan 29, 2018

(come on, I have to squat this number)

Fixes: #4828
Depends on: #4978, #4925, #4977
CF: #4820

I'm happy to take feedback on this over at pradyunsg#1.

@pradyunsg pradyunsg added type: feature request Request for a new feature C: check Checking dependency graph for consistency labels Jan 29, 2018
@pradyunsg pradyunsg added this to the 10.0 milestone Jan 29, 2018
@pradyunsg pradyunsg self-assigned this Jan 29, 2018
@pradyunsg pradyunsg mentioned this pull request Mar 1, 2018
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Mar 2, 2018
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 2, 2018
@pfmoore
Copy link
Member

pfmoore commented Mar 26, 2018

@pradyunsg Are you still hoping to get this in pip 10? It looks like it needs some work.

@pradyunsg
Copy link
Member Author

I do. I'm actually working on this rn. =)

@pradyunsg
Copy link
Member Author

Okay. One more thing - markers.

@pradyunsg
Copy link
Member Author

Great. Code is good. Now, docs and news next. Then a review (maybe?).

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Mar 29, 2018
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Mar 30, 2018
@pradyunsg
Copy link
Member Author

I'm skipping the documentation here because I'm not very sure whether it's needed or what it can say. If someone points out that they want information or more details, I imagine we'll get to know during the beta period.

@edmorley
Copy link
Contributor

edmorley commented May 7, 2018

@pradyunsg hi! After this change, are there any cases left were it's still necessary to run pip check in CI?

@pradyunsg
Copy link
Member Author

Running pip check when there's a broken dependency graph, will result in an exit code of 1. This PR doesn't change the exit code of pip install.

So, if you're running pip check today, keep doing that.

@pradyunsg pradyunsg deleted the resolver/warn-after-resolution branch May 21, 2018 15:13
@pradyunsg pradyunsg restored the resolver/warn-after-resolution branch May 27, 2018 09:38
@pradyunsg pradyunsg deleted the resolver/warn-after-resolution branch May 27, 2018 10:08
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: check Checking dependency graph for consistency type: feature request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pip check is case sensitive on distribution names
5 participants