Move dependency info and install order into Resolver #4925
Conversation
pradyunsg
added
type: refactor
| logger = logging.getLogger(__name__) | ||
|
|
||
|
|
||
| def install_given_reqs(to_install, install_options, global_options=(), |
There was a problem hiding this comment.
I'm not too happy I had to do this but I'm pretty sure that this function will move into a nicer place after a refactor of InstallRequirement, which I'll tackle after the Resolver is swapped in with the one from zazo.
|
It's sort of sad that only one test failed and I had to update 2 branches. This just substantially reduced the amount of confidence I have in the test suite. note to self: note to post on close is here. |
pradyunsg
force-pushed
the
resolver/move-dependency-info-and-install-order
branch
from
a622752 to
8803a31
Compare
|
When merging this PR, please use plain merge instead of squash/rebase merges since I have another branch sitting on top of this one now. |
|
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
pradyunsg
requested review from
a team
and removed request for
pfmoore and
dstufft
|
@pradyunsg Can this be deferred? It seems to be just an internal tidy-up, and I'm not sure it's worth rushing it just to hit the beta. I've skimmed the PR and while it looks OK, I don't think I've done a thorough enough job to call it a "review" :-) |
|
#5000 sits on top of this and I want that to make it through to 10.0. =) I am happy to let you decide whether you want that to be a part of 10.0. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
I couldn't split this into 2 PRs but this should be small enough too.