Fix PEP 518 support from VCS #5148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
type: enhancement
| @@ -715,7 +715,7 @@ def build(self, requirements, session, autobuilding=False): | |||
| pass | |||
| elif autobuilding and req.link and not req.link.is_artifact: | |||
| # VCS checkout. Build wheel just for this run. | |||
| ephem_cache = True | |||
| buildset.append((req, True)) | |||
There was a problem hiding this comment.
Wouldn't it be better to move the ephem_cache = False initialization above to the code block using it bellow?
|
Tested locally and I am happy with this. I don't have time to add a test. I'll do that later. :( |
|
This broke stuff -- #5251. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5142