Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PEP 518 support from VCS #5148

Merged
merged 2 commits into from
Apr 3, 2018
Merged

Fix PEP 518 support from VCS #5148

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abfbfcc
Actually build wheels for VCS checkouts
pradyunsg Apr 2, 2018
0de8931
Move initialization to a better place
pradyunsg Apr 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pip/_internal/wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,7 +715,7 @@ def build(self, requirements, session, autobuilding=False):
pass
elif autobuilding and req.link and not req.link.is_artifact:
# VCS checkout. Build wheel just for this run.
ephem_cache = True
buildset.append((req, True))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to move the ephem_cache = False initialization above to the code block using it bellow?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would. :)

elif autobuilding and not req.source_dir:
pass
else:
Expand Down