Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder conditionals to deal with installed VCS requirements #5280

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Reorder conditionals to deal with installed VCS requirements #5280

merged 2 commits into from
Apr 18, 2018

Conversation

pradyunsg
Copy link
Member

Fixes #5251

It turned out to be the order of the conditionals.

We didn't detect this previously, since:

  1. We weren't looking for this.
  2. The test suite does not check this behaviour? This needs fixing. I'll add a test in a subsequent PR (have an examination to study forrn)

@pradyunsg pradyunsg added type: bug A confirmed bug or unintended behavior !release blocker Hold a release until this is resolved C: vcs pip's interaction with version control systems like git, svn and bzr labels Apr 18, 2018
@pradyunsg pradyunsg self-assigned this Apr 18, 2018
@pradyunsg pradyunsg mentioned this pull request Apr 18, 2018
Closed
@pradyunsg pradyunsg added this to the 10.0.1 milestone Apr 18, 2018
@pradyunsg pradyunsg removed the !release blocker Hold a release until this is resolved label Apr 18, 2018
@pradyunsg pradyunsg removed this from the 10.0.1 milestone Apr 18, 2018
@pfmoore
Copy link
Member

pfmoore commented Apr 18, 2018

@pradyunsg You removed the 10.0.1 milestone. Is that because you don't want this merged before 10.0.1? If not, what's the plan for #5251?

@pradyunsg
Copy link
Member Author

This is the fix for that issue. I'm not sure why I did the removal of milestone and tag...

@pradyunsg pradyunsg added this to the 10.0.1 milestone Apr 18, 2018
@pfmoore
Copy link
Member

pfmoore commented Apr 18, 2018

Cool - no problem. It looks OK to me, want me to merge it?

@pradyunsg
Copy link
Member Author

Sure. I'll open another issue for following up with tests.

@pfmoore pfmoore merged commit 3c50345 into pypa:master Apr 18, 2018
@pradyunsg pradyunsg mentioned this pull request Apr 21, 2018
Closed
4 tasks
@pradyunsg pradyunsg deleted the fix/5251 branch May 27, 2018 10:08
@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
@pypa pypa unlocked this conversation Oct 7, 2022
@pypa pypa locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@pradyunsg pradyunsg

Labels
auto-locked Outdated issues that have been locked by automation C: vcs pip's interaction with version control systems like git, svn and bzr type: bug A confirmed bug or unintended behavior
Projects
None yet
Milestone
10.0.1
Development

Successfully merging this pull request may close these issues.

pip 10 is unable to install from non-editable VCS URLs
2 participants
@pradyunsg @pfmoore