Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder conditionals to deal with installed VCS requirements #5280

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Reorder conditionals to deal with installed VCS requirements #5280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
123e61d
Reorder conditionals to deal with installed VCS requirements
pradyunsg Apr 18, 2018
b610eab
:newspaper:
pradyunsg Apr 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/5251.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
A crash when reinstalling from VCS requirements has been fixed.
4 changes: 2 additions & 2 deletions src/pip/_internal/wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,11 +717,11 @@ def build(self, requirements, session, autobuilding=False):
)
elif autobuilding and req.editable:
pass
elif autobuilding and not req.source_dir:
pass
elif autobuilding and req.link and not req.link.is_artifact:
# VCS checkout. Build wheel just for this run.
buildset.append((req, True))
elif autobuilding and not req.source_dir:
pass
else:
ephem_cache = False
if autobuilding:
Expand Down