Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve user-facing network error message when requesting indexes #8738

Closed
wants to merge 6 commits into from
Closed

Improve user-facing network error message when requesting indexes #8738

wants to merge 6 commits into from

Conversation

uranusjr
Copy link
Member

@uranusjr uranusjr commented Aug 9, 2020 •
edited
Loading

Fix #8641.

  • Make sense of each exception classes
  • Make each exception print a message the user can see (warning? error?)
  • Add some documentation to link to in the user-facing error message
  • Improve the user-facing message
  • (Optional) Hide the ugly retry log if the user-facing message describes the situation well enough.

@uranusjr uranusjr changed the title Retry network error Improve user-facing network error message when requesting indexes Aug 9, 2020
@uranusjr
Rename NetworkConnectionError
4db6d46 
There are way too many exceptions that say "connection". Rename this
class so it's clear the exception is generated from an HTTP response,
not during connection.
@uranusjr
Make decoding functions more robust
102fb0a
@uranusjr
Output a warning when an HTTP page fails to load
2f6e82f 
This creates a message that the user can see. We will flesh out this
message to include better explainations for each situation in later
commits.
@uranusjr uranusjr force-pushed the retry-network-error branch 2 times, most recently from 8ce9a12 to e5ab371 Compare August 9, 2020 18:00
@uranusjr
Pass in more structured context into exception
bc37c60 
This may help us provide better error messages if needed, instead of
being stuck with an eagerly-rendered string.
@uranusjr
Add block to catch connection and proxy errors
f3a04ac 
This allows us to output a more specific error message to help users in
common cases.
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Aug 14, 2020
@pradyunsg
Copy link
Member

@uranusjr Is this something you'd be working on in the near future?

@uranusjr
Copy link
Member Author

It depends on your definition of near 😛 I worked on the user-facing message for this briefly with a sprint participant, but this will likely not progress very quickly in any case (the implementation is tedious and requires a lot of effor to untangle). I’d welcome anyone to to take over this if they have the time.

@pradyunsg pradyunsg mentioned this pull request Sep 18, 2021
Open
@pradyunsg
Copy link
Member

Closing this out, since this is significantly out of date. I might end up tackling this in #10421.

@pradyunsg pradyunsg closed this Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve network error message
3 participants
@uranusjr @BrownTruck @pradyunsg